Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix audio focus #1897

Merged
merged 2 commits into from
Feb 17, 2020
Merged

Fix audio focus #1897

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
723dfee
Fix audio focus
michaeltintiuc Feb 1, 2020
1ab82f7
Pause playback on focus loss
michaeltintiuc Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,10 @@ private DataSource.Factory buildDataSourceFactory(boolean useBandwidthMeter) {
public void onAudioFocusChange(int focusChange) {
switch (focusChange) {
case AudioManager.AUDIOFOCUS_LOSS:
eventEmitter.audioFocusChanged(false);
audioManager.abandonAudioFocus(this);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to abandon focus, should we pause automatically? still giving the user the option to stop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds fine, but my idea was to allow the dev to have full control of order of operations, but could be easily done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come to think of it, you're right, this is the right way of enforcing good behavior and will require no changes from the devs. Will add it ASAP,t hanks for the feedback!

break;
case AudioManager.AUDIOFOCUS_LOSS_TRANSIENT:
eventEmitter.audioFocusChanged(false);
break;
case AudioManager.AUDIOFOCUS_GAIN:
Expand Down