Fix/add pip config ios #2562
Closed
Fix/add pip config ios #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #2561 |
|
how's it going? Hey, how could you do picture-in-picture? I've been trying for many months but I haven't found any information. Could you help me? |
mattleff
suggested changes
Mar 28, 2022
| // Create new controller passing reference to the AVPlayerLayer | ||
| _pipController = [[AVPictureInPictureController alloc] initWithPlayerLayer:_playerLayer]; | ||
| _pipController.canStartPictureInPictureAutomaticallyFromInline = true; |
There was a problem hiding this comment.
Suggested change
| _pipController.canStartPictureInPictureAutomaticallyFromInline = true; | |
| if (@available(iOS 14.2, *)) { | |
| _pipController.canStartPictureInPictureAutomaticallyFromInline = true; | |
| } |
|
Closing due to lack of response (from the original submitted or anyone else to review and rebase). If someone wants to pick this up please open a new PR that ports this code into the current master. We are doing our best to start clean with v6 which requires being a bit aggressive in closing stale PRs that are over a year old. Please don't consider this dismissing of your work and contribution - it's greatly appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
Add audio configs required for PIP for iOS