Fix crash when the source is a cameraroll #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution! Can you please provide a working app sample that I can verify this fix with? Ideally use https://github.com/hueniverse/react-native-video-test and fork it with the changes needed to use the new feature. |
@hueniverse Thank you! I was tested my PR. You can see this https://github.com/virgil1996/react-native-video-test |
|
@virgil1996 Thank you. I tested it and it worked as expected. I would like one more reviewer to approve. Hopefully someone will volunteer. |
|
I have the same problem, it is still not possible to download this update? |
|
It should be other reviewer to approve |
armands-malejevs
approved these changes
Jun 21, 2022
|
The Obj-c implementation looks OK to me, but it will need to be converted to Swift to be mergeable. |
|
@nickfujita Is this something you can take care of? |
freeboub
approved these changes
Jun 23, 2022
hueniverse
added
help wanted
|
@hueniverse Hello, I was converted to Swift version. But I'm not familiar with this way of writing, you can see if you have any suggestions |
|
@freeboub should be back from vacation soon and will review again. Thanks @virgil1996 |
freeboub
approved these changes
Aug 1, 2022
freeboub
approved these changes
Aug 1, 2022
renovate bot
referenced
this pull request
in valora-inc/wallet
Nov 22, 2023
…4499) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-video](https://github.com/react-native-community/react-native-video) | [`^6.0.0-alpha.7` -> `^6.0.0-alpha.11`](https://renovatebot.com/diffs/npm/react-native-video/6.0.0-alpha.7/6.0.0-alpha.11) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-video (react-native-video)</summary> ### [`v6.0.0-alpha.11`](https://github.com/react-native-community/react-native-video/blob/HEAD/CHANGELOG.md#600-alpha11-2023-11-15) [Compare Source](https://github.com/react-native-community/react-native-video/compare/v6.0.0-alpha.10...v6.0.0-alpha.11) ##### Bug Fixes - fix bad package release process ([#​3347](https://github.com/react-native-video/react-native-video/issues/3347)) ([f961f95](https://github.com/react-native-video/react-native-video/commit/f961f952a483192ee3de1f7bae59419ec6ddc5b7)) ### [`v6.0.0-alpha.10`](https://github.com/react-native-community/react-native-video/blob/HEAD/CHANGELOG.md#600-alpha10-2023-11-13) [Compare Source](https://github.com/react-native-community/react-native-video/compare/v6.0.0-alpha.9...v6.0.0-alpha.10) ##### Bug Fixes - fixes where Android's muted prop behavior differs from iOS ([#​3339](https://github.com/react-native-video/react-native-video/issues/3339)) ([8fbdc28](https://github.com/react-native-video/react-native-video/commit/8fbdc28a73a0b3ffd3691ef0c8cf523c760ae288)) - **ios:** fix wrong fullscreen method definition ([#​3338](https://github.com/react-native-video/react-native-video/issues/3338)) ([7f49b56](https://github.com/react-native-video/react-native-video/commit/7f49b560278262fb4276f931404c70672a6445c8)) - **ios:** player is frozen after re-focusing on the app ([#​3326](https://github.com/react-native-video/react-native-video/issues/3326)) ([722ae34](https://github.com/react-native-video/react-native-video/commit/722ae3477a68aecb812b26d71ea22a17dda71f50)) ##### Features - add `onVolumeChange` event ([#​3322](https://github.com/react-native-video/react-native-video/issues/3322)) ([cdbc856](https://github.com/react-native-video/react-native-video/commit/cdbc85638789da0002cdadb13190963d4c1332c2)) - add release-it ([#​3342](https://github.com/react-native-video/react-native-video/issues/3342)) ([da27089](https://github.com/react-native-video/react-native-video/commit/da270891fbce485bb132825a336638f2af98408d)) - **ios:** add onBandwidthUpdate event ([#​3331](https://github.com/react-native-video/react-native-video/issues/3331)) ([9054db3](https://github.com/react-native-video/react-native-video/commit/9054db35d7d5e4e6d54739fc9349576c03522d7c)) #### Changelog #### Next - Android, iOS: add onVolumeChange event [#​3322](https://github.com/react-native-community/react-native-video/issues/3322) ##### Version 6.0.0-alpha.9 - All: add built-in typescript support [#​3266](https://github.com/react-native-video/react-native-video/pull/3266) - All: update documentation generation [#​3296](https://github.com/react-native-video/react-native-video/pull/3296) - **BREAKING CHANGE**❗️Android: update isCodecSupported to return enum [#​3254](https://github.com/react-native-video/react-native-video/pull/3254) - Android: use explicit not-exported flag for AudioBecomingNoisyReceiver [#​3327](https://github.com/react-native-video/react-native-video/pull/3327) - Android: remove kotlin-android-extensions [#​3299](https://github.com/react-native-video/react-native-video/pull/3299) - Android: ensure audio volume is changed in UI thread [3292](https://github.com/react-native-video/react-native-video/pull/3292) - Android: multiple internal refactor and switch to kotlin - Android: refactor log management and add an option to increase log verbosity [#​3277](https://github.com/react-native-video/react-native-video/pull/3277) - iOS: Fix audio session category when not using the audioOutput prop - iOS: implement onPlaybackStateChanged callback [#​3307](https://github.com/react-native-video/react-native-video/pull/3307) - iOS: remove false calls at onPlaybackRateChange [#​3306](https://github.com/react-native-video/react-native-video/pull/3306) - iOS: audio does not work with headphones [#​3284](https://github.com/react-native-video/react-native-video/pull/3284) - iOS: Resuming video ad after closing the in-app browser on iOS [#​3275](https://github.com/react-native-video/react-native-video/pull/3275) - iOS, Android: expose playback functions to ref [#​3245](https://github.com/react-native-video/react-native-video/pull/3245) - tvOS: fix build: [#​3276](https://github.com/react-native-video/react-native-video/pull/3276) - Windows: fix build error from over-specified SDK version [#​3246](https://github.com/react-native-video/react-native-video/pull/3246) - Windows: fix `onError` not being raised [#​3247](https://github.com/react-native-video/react-native-video/pull/3247) ##### Version 6.0.0-alpha.8 - All: Playing audio over earpiece [#​2887](https://github.com/react-native-video/react-native-video/issues/2887) - All: Prepare for fabric [#​3175](https://github.com/react-native-video/react-native-video/pull/3175) [#]() - iOS: Fix Pip [#​3221](https://github.com/react-native-video/react-native-video/pull/3221) - iOS: Fix regression in presentFullscreenPlayer & dismissFullscreenPlayer [#​3230](https://github.com/react-native-video/react-native-video/pull/3230) - tvOS: Fix build [#​3207](https://github.com/react-native-video/react-native-video/pull/3207) - tvOS: Add sample [#​3208](https://github.com/react-native-video/react-native-video/pull/3208) - tvOS: Allow chapter customization [#​3216](https://github.com/react-native-video/react-native-video/pull/3216) - doc: Fix internal links [#​3229](https://github.com/react-native-video/react-native-video/pull/3229) ##### Version 6.0.0-alpha.7 - All: clean JS warnings ([https://github.com/react-native-video/react-native-video/pull/3183](https://github.com/react-native-video/react-native-video/pull/3183)) - Android: Add shutterView color configurtion ([https://github.com/react-native-video/react-native-video/pull/3179](https://github.com/react-native-video/react-native-video/pull/3179)) - Android: React native 0.73 support ([https://github.com/react-native-video/react-native-video/pull/3163](https://github.com/react-native-video/react-native-video/pull/3163)) - Android: Fix memory leaks from AudioManager [#​3123](https://github.com/react-native-video/react-native-video/pull/3123) - Android: Fixed syntax error [#​3182](https://github.com/react-native-video/react-native-video/issues/3182) - iOS: Fix freeze at playback startup ([https://github.com/react-native-video/react-native-video/pull/3173](https://github.com/react-native-video/react-native-video/pull/3173)) - iOS: Various safety checks ([https://github.com/react-native-video/react-native-video/pull/3168](https://github.com/react-native-video/react-native-video/pull/3168)) ##### Version 6.0.0-alpha.6 - Feature: Video range support [#​3030](https://github.com/react-native-video/react-native-video/pull/3030) - iOS: remove undocumented `currentTime` property [#​3064](https://github.com/react-native-video/react-native-video/pull/3064) - iOS: make sure that the audio in ads is muted when the player is muted. [#​3068](https://github.com/react-native-video/react-native-video/pull/3077) - iOS: make IMA build optionnal ##### Version 6.0.0-alpha.5 - iOS: ensure controls are not displayed when disabled by user [#​3017](https://github.com/react-native-video/react-native-video/pull/3017) - iOS: app crashes on call to presentFullScreenPlayer [#​2808](https://github.com/react-native-video/react-native-video/pull/2971) - Android: Fix publicated progress handler causing duplicated progress event [#​2972](https://github.com/react-native-video/react-native-video/pull/2972) - Android: Fix audio/Subtitle tracks selection [#​2979](https://github.com/react-native-video/react-native-video/pull/2979) - Android: add new events on tracks changed to be notified of audio/text/video Tracks update during playback [2806](https://github.com/react-native-video/react-native-video/pull/2806) - Feature: Add VAST support for AVOD [#​2923](https://github.com/react-native-video/react-native-video/pull/2923) - Sample: Upgrade react-native version of basic sample [#​2960](https://github.com/react-native-video/react-native-video/pull/2960) ##### Version 6.0.0-alpha.4 - ensure src is always provided to native player even if it is invalid [#​2857](https://github.com/react-native-video/react-native-video/pull/2857) - Sample: Add react-native-video controls support [#​2852](https://github.com/react-native-video/react-native-video/pull/2852) - Android: Switch Google's maven repository to default `google()` [#​2860](https://github.com/react-native-video/react-native-video/pull/2860) - Android: Implement focusable prop so the video view can toggle whether it is focusable for non-touch devices [#​2819](https://github.com/react-native-video/react-native-video/issues/2819) - Android: fix linter warning \[[#​2891](https://github.com/react-native-community/react-native-video/issues/2891)] ([https://github.com/react-native-video/react-native-video/pull/2891](https://github.com/react-native-video/react-native-video/pull/2891)) - Fix iOS RCTSwiftLog naming collision [#​2868](https://github.com/react-native-video/react-native-video/issues/2868) - Added "homepage" to package.json [#​2882](https://github.com/react-native-video/react-native-video/pull/2882) - Fix regression when fullscreen prop is used combined with controls [#​2911](https://github.com/react-native-video/react-native-video/pull/2911) - Fix: memory leak issue on iOS [#​2907](https://github.com/react-native-video/react-native-video/pull/2907) - Fix setting text tracks before player is initialized on iOS [#​2935](https://github.com/react-native-video/react-native-video/pull/2935) ##### Version 6.0.0-alpha.3 - Fix ios build [#​2854](https://github.com/react-native-video/react-native-video/pull/2854) ##### Version 6.0.0-alpha.2 - Upgrade ExoPlayer to 2.18.1 [#​2846](https://github.com/react-native-video/react-native-video/pull/2846) - Feature add new APIs to query supported features of device decoder (widevine level & codec capabilities) on android [#​2740](https://github.com/react-native-video/react-native-video/pull/2740) - Feature add support of subtitle styling on android [#​2759](https://github.com/react-native-video/react-native-video/pull/2759) - Fix Android [#​2690](https://github.com/react-native-community/react-native-video/issues/2690) ensure onEnd is not sent twice [#​2690](https://github.com/react-native-video/react-native-video/issues/2690) - Fix Exoplayer progress not reported when paused [#​2664](https://github.com/react-native-video/react-native-video/pull/2664) - Call playbackRateChange onPlay and onPause [#​1493](https://github.com/react-native-video/react-native-video/pull/1493) - Fix being unable to disable sideloaded texttracks in the AVPlayer [#​2679](https://github.com/react-native-video/react-native-video/pull/2679) - Fixed crash when iOS seek method called reject on the promise [#​2743](https://github.com/react-native-video/react-native-video/pull/2743) - Fix maxBitRate property being ignored on Android [#​2670](https://github.com/react-native-video/react-native-video/pull/2670) - Fix crash when the source is a cameraroll \[[#​2639](https://github.com/react-native-community/react-native-video/issues/2639)] ([https://github.com/react-native-video/react-native-video/pull/2639](https://github.com/react-native-video/react-native-video/pull/2639)) - Fix IOS UI frame drop on loading video \[[#​2848](https://github.com/react-native-community/react-native-video/issues/2848)] ([https://github.com/react-native-video/react-native-video/pull/2848](https://github.com/react-native-video/react-native-video/pull/2848)) ##### Version 6.0.0-alpha.1 - Remove Android MediaPlayer support [#​2724](https://github.com/react-native-video/react-native-video/pull/2724) **WARNING**: when switching from older version to V6, you need to remove all refrerences of android-exoplayer. This android-exoplayer folder has been renamed to android. Exoplayer is now the only player implementation supported. - Replace Image.propTypes with ImagePropTypes. [#​2718](https://github.com/react-native-video/react-native-video/pull/2718) - Fix iOS build caused by type mismatch [#​2720](https://github.com/react-native-video/react-native-video/pull/2720) - ERROR TypeError: undefined is not an object (evaluating '\_reactNative.Image.propTypes.resizeMode') [#​2714](https://github.com/react-native-video/react-native-video/pull/2714) - Fix video endless loop when repeat set to false or not specified. [#​2329](https://github.com/react-native-video/react-native-video/pull/2329) ##### Version 6.0.0-alpha.0 - Support disabling buffering [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Fix AudioFocus bug that could cause the player to stop responding to play/pause in some instances. [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Fix player crashing when it is being cleared. [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Add support for customising back buffer duration and handle network errors gracefully to prevent releasing the player when network is lost. [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Allow player to be init before source is provided, and later update once a source is provided. [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Adds handling for providing a empty source in order to stop playback and clear out any existing content [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Add support for detecting if format is supported and exclude unsupported resolutions from auto quality selection and video track info in RN. [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Improve error handling [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Add support for L1 to L3 Widevine fallback if playback fails initially. [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Reduce buffer size based on available heap [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Force garbage collection when there is no available memory [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Improve memory usage [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Support disabling screen recording [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Improved error capturing [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Fix DRM init crashes [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Improve progress reporting [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Fix progress loss when network connection is regained [#​2689](https://github.com/react-native-video/react-native-video/pull/2689) - Add Google's maven repository to avoid build error [#​2552](https://github.com/react-native-video/react-native-video/pull/2552) - Fix iOS 15.4 HLS playback race condition [#​2633](https://github.com/react-native-video/react-native-video/pull/2633) - Fix app crash from NPE in Exoplayer error handler [#​2575](https://github.com/react-native-video/react-native-video/pull/2575) - Fix default closed captioning behavior for Android ExoPlayer [#​2181](https://github.com/react-native-video/react-native-video/pull/2181) - Disable pipController init if pictureInPicture is false [#​2645](https://github.com/react-native-video/react-native-video/pull/2645) - Make sure modifiers are applied before playing [#​2395](https://github.com/react-native-video/react-native-video/pull/2395) - Better support newer versions of RNW (64 and newer) [#​2535](https://github.com/react-native-video/react-native-video/pull/2535) - Fix nil string uri parameter error [#​695](https://github.com/react-native-video/react-native-video/pull/695) - (Breaking) Bump shaka-player to 3.3.2 [#​2587](https://github.com/react-native-video/react-native-video/pull/2587) - Improve basic player example on android [#​2662](https://github.com/react-native-video/react-native-video/pull/2662) - Ensure we always use `hideShutterView` before showing the `shutterView` on Android [#​2609](https://github.com/react-native-video/react-native-video/pull/2609) - Convert iOS implementation to Swift [#​2527](https://github.com/react-native-video/react-native-video/pull/2527) - Add iOS support for decoding offline sources [#​2527](https://github.com/react-native-video/react-native-video/pull/2527) - Update basic example applications (React Native 0.63.4) [#​2527](https://github.com/react-native-video/react-native-video/pull/2527) - Upgrade ExoPlayer to 2.17.1 [#​2498](https://github.com/react-native-video/react-native-video/pull/2498) - Fix volume reset issue in exoPlayer [#​2371](https://github.com/react-native-video/react-native-video/pull/2371) - Change WindowsTargetPlatformVersion to 10.0 [#​2706](https://github.com/react-native-video/react-native-video/pull/2706) - Fixed Android seeking bug [#​2712](https://github.com/react-native-video/react-native-video/pull/2712) - Fixed `onReadyForDisplay` not being called [#​2721](https://github.com/react-native-video/react-native-video/pull/2721) - Fix type of `_eventDispatcher` on iOS target to match `bridge.eventDispatcher()` [#​2720](https://github.com/react-native-video/react-native-video/pull/2720) ##### Version 5.2.0 - Fix for tvOS native audio menu language selector - Update ExoPlayer to allow pre-init and content clear \[[#​2412](https://github.com/react-native-community/react-native-video/issues/2412)] ([https://github.com/react-native-video/react-native-video/pull/2412](https://github.com/react-native-video/react-native-video/pull/2412)) - iOS rate is reset to 1.0 after play/pause \[[#​2167](https://github.com/react-native-community/react-native-video/issues/2167)] ([https://github.com/react-native-video/react-native-video/pull/2167](https://github.com/react-native-video/react-native-video/pull/2167)) - Upgrade ExoPlayer to 2.13.2 \[[#​2317](https://github.com/react-native-community/react-native-video/issues/2317)] ([https://github.com/react-native-video/react-native-video/pull/2317](https://github.com/react-native-video/react-native-video/pull/2317)) - Fix AudioFocus pausing video when attempting to play \[[#​2311](https://github.com/react-native-community/react-native-video/issues/2311)] ([https://github.com/react-native-video/react-native-video/pull/2311](https://github.com/react-native-video/react-native-video/pull/2311)) ##### Version 5.1.0-alpha9 - Add ARM64 support for windows [#​2137](https://github.com/react-native-community/react-native-video/pull/2137) - Fix deprecated API bug for windows [#​2119](https://github.com/react-native-video/react-native-video/pull/2119) - Added `rate` property and autolinking support for windows [#​2206](https://github.com/react-native-video/react-native-video/pull/2206) ##### Version 5.1.0-alpha8 - Fixing ID3 Frame Error When Receiving EventMessage in TimedMetadata [#​2116](https://github.com/react-native-community/react-native-video/pull/2116) ##### Version 5.1.0-alpha7 - Basic support for DRM on iOS and Android [#​1445](https://github.com/react-native-community/react-native-video/pull/1445) ##### Version 5.1.0-alpha6 - Fix iOS bug which would break size of views when video is displayed with controls on a non full-screen React view. [#​1931](https://github.com/react-native-community/react-native-video/pull/1931) - Fix video dimensions being undefined when playing HLS in ios. [#​1992](https://github.com/react-native-community/react-native-video/pull/1992) - Add support for audio mix with other apps for iOS. [#​1978](https://github.com/react-native-community/react-native-video/pull/1978) - Properly implement pending seek for iOS. [#​1994](https://github.com/react-native-community/react-native-video/pull/1994) - Added `preferredForwardBufferDuration` (iOS) - the duration the player should buffer media from the network ahead of the playhead to guard against playback disruption. ([#​1944](https://github.com/react-native-community/react-native-video/issues/1944)) - Added `currentPlaybackTime` (Android ExoPlayer, iOS) - when playing an HLS live stream with a `EXT-X-PROGRAM-DATE-TIME` tag configured, then this property will contain the epoch value in msec. ([#​1944](https://github.com/react-native-community/react-native-video/issues/1944)) - Added `trackId` (Android ExoPlayer) - Configure an identifier for the video stream to link the playback context to the events emitted. ([#​1944](https://github.com/react-native-community/react-native-video/issues/1944)) - Added preventsDisplaySleepDuringVideoPlayback ([#​2019](https://github.com/react-native-community/react-native-video/issues/2019)) - Reverted the JS fullscreening for Android. [#​2013](https://github.com/react-native-community/react-native-video/pull/2013) - Set iOS request headers without needing to edit RCTVideo.m. [#​2014](https://github.com/react-native-community/react-native-video/pull/2014) - Fix exoplayer aspect ratio update on source changes [#​2053](https://github.com/react-native-community/react-native-video/pull/2053) ##### Version 5.1.0-alpha5 - Add support for react-native Windows Cpp/WinRT(https://github.com/react-native-community/react-native-video/pull/1893)-video/pull/1893\)) ##### Version 5.1.0-alpha4 - Fix android play/pause bug related to full-screen mode [#​1916](https://github.com/react-native-community/react-native-video/pull/1916) ##### Version 5.1.0-alpha3 - Improve Android Audio Focus [#​1897](https://github.com/react-native-community/react-native-video/pull/1897) ##### Version 5.1.0-alpha2 - Added support for full-screen functionality in Android Exoplayer [#​1730](https://github.com/react-native-community/react-native-video/pull/1730) ##### Version 5.1.0-alpha1 - Fixed Exoplayer doesn't work with mute=true (Android). [#​1696](https://github.com/react-native-community/react-native-video/pull/1696) - Added support for automaticallyWaitsToMinimizeStalling property (iOS) [#​1723](https://github.com/react-native-community/react-native-video/pull/1723) - Bump Exoplayer to 2.10.4, remove deprecated usages of Exoplayer methods (Android). [#​1753](https://github.com/react-native-community/react-native-video/pull/1753) - Preserve Exoplayer BandwidthMeter instance across video plays, this should noticeably improve streaming bandwidth detection (Android). ##### Version 5.0.2 - Fix crash when RCTVideo's superclass doesn't observe the keyPath 'frame' (iOS) [#​1720](https://github.com/react-native-community/react-native-video/pull/1720) ##### Version 5.0.1 - Fix AndroidX Support bad merge ##### Version 5.0.0 \[Deprecated] - AndroidX Support ##### Version 4.4.4 - Handle racing conditions when props are settled on Exoplayer ##### Version 4.4.3 - Fix mute/unmute when controls are present (iOS) [#​1654](https://github.com/react-native-community/react-native-video/pull/1654) - Fix Android videos being able to play with background music/audio from other apps. - Fixed memory leak on iOS when using `controls` [#​1647](https://github.com/react-native-community/react-native-video/pull/1647) - (Android) Update gradle and target SDK [#​1629](https://github.com/react-native-community/react-native-video/pull/1629) - Fix iOS stressed mount/unmount crash [#​1646](https://github.com/react-native-community/react-native-video/pull/1646) ##### Version 4.4.2 - Change compileOnly to implementation on gradle (for newer gradle versions and react-native 0.59 support) [#​1592](https://github.com/react-native-community/react-native-video/pull/1592) - Replaced RCTBubblingEventBlock events by RCTDirectEventBlock to avoid event name collisions [#​1625](https://github.com/react-native-community/react-native-video/pull/1625) - Added `onPlaybackRateChange` to README [#​1578](https://github.com/react-native-community/react-native-video/pull/1578) - Added `onReadyForDisplay` to README [#​1627](https://github.com/react-native-community/react-native-video/pull/1627) - Improved handling of poster image. Fixes bug with displaying video and poster simultaneously. [#​1627](https://github.com/react-native-community/react-native-video/pull/1627) - Fix background audio stopping on iOS when using `controls` [#​1614](https://github.com/react-native-community/react-native-video/pull/1614) ##### Version 4.4.1 - Fix tvOS picture-in-picture compilation regression [#​1518](https://github.com/react-native-community/react-native-video/pull/1518) - fullscreen rotation issues with iOS built-in controls [#​1441](https://github.com/react-native-community/react-native-video/pull/1441) - Fix player freeze when playing audio files on ExoPlayer [#​1529](https://github.com/react-native-community/react-native-video/pull/1529) ##### Version 4.4.0 - Fix runtime warning by replacing `UIManager.RCTVideo` with `UIManager.getViewManagerConfig('RCTVideo')` (and ensuring backwards compat) [#​1487](https://github.com/react-native-community/react-native-video/pull/1487) - Fix loading package resolved videos when using video-caching [#​1438](https://github.com/react-native-community/react-native-video/pull/1438) - Fix "message sent to deallocated instance" crash on ios [#​1482](https://github.com/react-native-community/react-native-video/pull/1482) - Display a warning when source is empty [#​1478](https://github.com/react-native-community/react-native-video/pull/1478) - Don't crash on iOS for an empty source [#​1246](https://github.com/react-native-community/react-native-video/pull/1246) - Recover from from transient internet failures when loading on ExoPlayer [#​1448](https://github.com/react-native-community/react-native-video/pull/1448) - Add controls support for ExoPlayer [#​1414](https://github.com/react-native-community/react-native-video/pull/1414) - Fix check for text tracks when iOS caching enabled [#​1387](https://github.com/react-native-community/react-native-video/pull/1387) - Add support for Picture in Picture on iOS [#​1325](https://github.com/react-native-community/react-native-video/pull/1325) - Fix UIManager undefined variable [#​1488](https://github.com/react-native-community/react-native-video/pull/1488) ##### Version 4.3.0 - Fix iOS video not displaying after switching source [#​1395](https://github.com/react-native-community/react-native-video/pull/1395) - Add the filterEnabled flag, fixes iOS video start time regression [#​1384](https://github.com/react-native-community/react-native-video/pull/1384) - Fix text not appearing in release builds of Android apps [#​1373](https://github.com/react-native-community/react-native-video/pull/1373) - Update to ExoPlayer 2.9.3 [#​1406](https://github.com/react-native-community/react-native-video/pull/1406) - Add video track selection & onBandwidthUpdate [#​1199](https://github.com/react-native-community/react-native-video/pull/1199) - Recovery from transient internet failures and props to configure the custom retry count [#​1448](https://github.com/react-native-community/react-native-video/pull/1448) ##### Version 4.2.0 - Don't initialize filters on iOS unless a filter is set. This was causing a startup performance regression [#​1360](https://github.com/react-native-community/react-native-video/pull/1360) - Support setting the maxBitRate [#​1310](https://github.com/react-native-community/react-native-video/pull/1310) - Fix useTextureView not defaulting to true [#​1383](https://github.com/react-native-community/react-native-video/pull/1383) - Fix crash on MediaPlayer w/ Android 4.4 & avoid memory leak [#​1328](https://github.com/react-native-community/react-native-video/pull/1328) ##### Version 4.1.0 - Generate onSeek on Android ExoPlayer & MediaPlayer after seek completes [#​1351](https://github.com/react-native-community/react-native-video/pull/1351) - Remove unneeded onVideoSaved event [#​1350](https://github.com/react-native-community/react-native-video/pull/1350) - Disable AirPlay if sidecar text tracks are enabled [#​1304](https://github.com/react-native-community/react-native-video/pull/1304) - Add possibility to remove black screen while video is loading in Exoplayer [#​1355](https://github.com/react-native-community/react-native-video/pull/1355) ##### Version 4.0.1 - Add missing files to package.json [#​1342](https://github.com/react-native-community/react-native-video/pull/1342) ##### Version 4.0.0 - Partial support for timed metadata on Android MediaPlayer [#​707](https://github.com/react-native-community/react-native-video/pull/707) - Support video caching for iOS [#​955](https://github.com/react-native-community/react-native-video/pull/955) - Video caching cleanups [#​1172](https://github.com/react-native-community/react-native-video/pull/1172) - Add ipod-library support [#​926](https://github.com/react-native-community/react-native-video/pull/926/files) - Fix crash on ExoPlayer when there are no audio tracks [#​1233](https://github.com/react-native-community/react-native-video/pull/1233) - Reduce package size [#​1231](https://github.com/react-native-community/react-native-video/pull/1231) - Remove unnecessary import in TextTrackType [#​1229](https://github.com/react-native-community/react-native-video/pull/1229) - Prevent flash between poster and video [#​1167](https://github.com/react-native-community/react-native-video/pull/1167) - Support react-native-dom [#​1253](https://github.com/react-native-community/react-native-video/pull/1253) - Update to ExoPlayer 2.8.2. Android SDK 26 now required [#​1170](https://github.com/react-native-community/react-native-video/pull/1170) - Update to ExoPlayer 2.8.4 [#​1266](https://github.com/react-native-community/react-native-video/pull/1266) - Add fullscreenOrientation option for iOS [#​1215](https://github.com/react-native-community/react-native-video/pull/1215) - Update to ExoPlayer 2.9.0 [#​1285](https://github.com/react-native-community/react-native-video/pull/1285) - Switch useTextureView to default to `true` [#​1286](https://github.com/react-native-community/react-native-video/pull/1286) - Re-add fullscreenAutorotate prop [#​1303](https://github.com/react-native-community/react-native-video/pull/1303) - Make seek throw a useful error for NaN values [#​1283](https://github.com/react-native-community/react-native-video/pull/1283) - Video Filters and Save Video [#​1306](https://github.com/react-native-community/react-native-video/pull/1306) - Fix: volume should not change on onAudioFocusChange event [#​1327](https://github.com/react-native-community/react-native-video/pull/1327) - Update ExoPlayer to 2.9.1 and OkHTTP to 3.12.0 [#​1338](https://github.com/react-native-community/react-native-video/pull/1338) ##### Version 3.2.0 - Basic fullscreen support for Android MediaPlayer [#​1138](https://github.com/react-native-community/react-native-video/pull/1138) - Simplify default Android SDK code [#​1145](https://github.com/react-native-community/react-native-video/pull/1145) [#​1146](https://github.com/react-native-community/react-native-video/pull/1146) - Various iOS sideloaded text track fixes [#​1157](https://github.com/react-native-community/react-native-video/pull/1157) - Fix [#​1150](https://github.com/react-native-community/react-native-video/issues/1150) where assets with bundled assets don't work on iOS in release mode [#​1162](https://github.com/react-native-community/react-native-video/pull/1162) - Support configuring the buffer on Android ExoPlayer [#​1160](https://github.com/react-native-community/react-native-video/pull/1160) - Prevent sleep from sleeping while videos are playing on Android MediaPlayer [#​1117](https://github.com/react-native-community/react-native-video/pull/1117) - Update NewtonSoft JSON to match react-native-windows version [#​1169](https://github.com/react-native-community/react-native-video/pull/1169) ##### Version 3.1.0 - Support sidecar text tracks on iOS [#​1109](https://github.com/react-native-community/react-native-video/pull/1109) - Support onAudioBecomingNoisy on iOS [#​1131](https://github.com/react-native-community/react-native-video/pull/1131) ##### Version 3.0 - Inherit Android buildtools and SDK version from the root project [#​1081](https://github.com/react-native-community/react-native-video/pull/1081) - Automatically play on ExoPlayer when the paused prop is not set [#​1083](https://github.com/react-native-community/react-native-video/pull/1083) - Preserve Android MediaPlayer paused prop when backgrounding [#​1082](https://github.com/react-native-community/react-native-video/pull/1082) - Support specifying headers on ExoPlayer as part of the source [#​805](https://github.com/react-native-community/react-native-video/pull/805) - Prevent iOS onLoad event during seeking [#​1088](https://github.com/react-native-community/react-native-video/pull/1088) - ExoPlayer playableDuration incorrect [#​1089](https://github.com/react-native-community/react-native-video/pull/1089) ##### Version 2.3.1 - Revert PR to inherit Android SDK versions from root project. Re-add in 3.0 [#​1080](https://github.com/react-native-community/react-native-video/pull/1080) ##### Version 2.3.0 - Support allowsExternalPlayback on iOS [#​1057](https://github.com/react-native-community/react-native-video/pull/1057) - Inherit Android buildtools and SDK version from the root project [#​999](https://github.com/react-native-community/react-native-video/pull/999) - Fix bug that caused ExoPlayer to start paused if playInBackground was set [#​833](https://github.com/react-native-community/react-native-video/pull/833) - Fix crash if clearing an observer on iOS that was already cleared [#​1075](https://github.com/react-native-community/react-native-video/pull/1075) - Add audioOnly prop for music files [#​1039](https://github.com/react-native-community/react-native-video/pull/1039) - Support seeking with more exact tolerance on iOS [#​1076](https://github.com/react-native-community/react-native-video/pull/1076) ##### Version 2.2.0 - Text track selection support for iOS & ExoPlayer [#​1049](https://github.com/react-native-community/react-native-video/pull/1049) - Support outputting to a TextureView on Android ExoPlayer [#​1058](https://github.com/react-native-community/react-native-video/pull/1058) - Support changing the left/right balance on Android MediaPlayer [#​1051](https://github.com/react-native-community/react-native-video/pull/1051) - Prevent multiple onEnd notifications on iOS [#​832](https://github.com/react-native-community/react-native-video/pull/832) - Fix doing a partial swipe on iOS causing a black screen [#​1048](https://github.com/react-native-community/react-native-video/pull/1048) - Fix crash when switching to a new source on iOS [#​974](https://github.com/react-native-community/react-native-video/pull/974) - Add cookie support for ExoPlayer [#​922](https://github.com/react-native-community/react-native-video/pull/922) - Remove ExoPlayer onMetadata that wasn't being used [#​1040](https://github.com/react-native-community/react-native-video/pull/1040) - Fix bug where setting the progress interval on iOS didn't work [#​800](https://github.com/react-native-community/react-native-video/pull/800) - Support setting the poster resize mode [#​595](https://github.com/react-native-community/react-native-video/pull/595) ### [`v6.0.0-alpha.9`](https://github.com/react-native-community/react-native-video/blob/HEAD/CHANGELOG.md#Version-600-alpha9) [Compare Source](https://github.com/react-native-community/react-native-video/compare/v6.0.0-alpha.8...v6.0.0-alpha.9) - All: add built-in typescript support [#​3266](https://github.com/react-native-video/react-native-video/pull/3266) - All: update documentation generation [#​3296](https://github.com/react-native-video/react-native-video/pull/3296) - **BREAKING CHANGE**❗️Android: update isCodecSupported to return enum [#​3254](https://github.com/react-native-video/react-native-video/pull/3254) - Android: use explicit not-exported flag for AudioBecomingNoisyReceiver [#​3327](https://github.com/react-native-video/react-native-video/pull/3327) - Android: remove kotlin-android-extensions [#​3299](https://github.com/react-native-video/react-native-video/pull/3299) - Android: ensure audio volume is changed in UI thread [3292](https://github.com/react-native-video/react-native-video/pull/3292) - Android: multiple internal refactor and switch to kotlin - Android: refactor log management and add an option to increase log verbosity [#​3277](https://github.com/react-native-video/react-native-video/pull/3277) - iOS: Fix audio session category when not using the audioOutput prop - iOS: implement onPlaybackStateChanged callback [#​3307](https://github.com/react-native-video/react-native-video/pull/3307) - iOS: remove false calls at onPlaybackRateChange [#​3306](https://github.com/react-native-video/react-native-video/pull/3306) - iOS: audio does not work with headphones [#​3284](https://github.com/react-native-video/react-native-video/pull/3284) - iOS: Resuming video ad after closing the in-app browser on iOS [#​3275](https://github.com/react-native-video/react-native-video/pull/3275) - iOS, Android: expose playback functions to ref [#​3245](https://github.com/react-native-video/react-native-video/pull/3245) - tvOS: fix build: [#​3276](https://github.com/react-native-video/react-native-video/pull/3276) - Windows: fix build error from over-specified SDK version [#​3246](https://github.com/react-native-video/react-native-video/pull/3246) - Windows: fix `onError` not being raised [#​3247](https://github.com/react-native-video/react-native-video/pull/3247) ### [`v6.0.0-alpha.8`](https://github.com/react-native-community/react-native-video/blob/HEAD/CHANGELOG.md#Version-600-alpha8) [Compare Source](https://github.com/react-native-community/react-native-video/compare/v6.0.0-alpha.7...v6.0.0-alpha.8) - All: Playing audio over earpiece [#​2887](https://github.com/react-native-video/react-native-video/issues/2887) - All: Prepare for fabric [#​3175](https://github.com/react-native-video/react-native-video/pull/3175) [#]() - iOS: Fix Pip [#​3221](https://github.com/react-native-video/react-native-video/pull/3221) - iOS: Fix regression in presentFullscreenPlayer & dismissFullscreenPlayer [#​3230](https://github.com/react-native-video/react-native-video/pull/3230) - tvOS: Fix build [#​3207](https://github.com/react-native-video/react-native-video/pull/3207) - tvOS: Add sample [#​3208](https://github.com/react-native-video/react-native-video/pull/3208) - tvOS: Allow chapter customization [#​3216](https://github.com/react-native-video/react-native-video/pull/3216) - doc: Fix internal links [#​3229](https://github.com/react-native-video/react-native-video/pull/3229) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Satish Ravi <satish.ravi@valoraapp.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR support load iOS cameraroll
Closes #2652