fix: remove dummy nativeOnly #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sunbreak
force-pushed
the
fabric-1
branch
2 times, most recently
from
c1ee7e6 to
86d4c87
Compare
|
Hey @Sunbreak , Where are you on this? I would like to help you. |
|
It is WIP. I'll let you known if it is ready |
freeboub
reviewed
Apr 5, 2023
| @@ -571,10 +563,4 @@ Video.propTypes = { | |||
| ...ViewPropTypes, | |||
| }; | |||
|
|
|||
| const RCTVideo = requireNativeComponent('RCTVideo', Video, { | |||
There was a problem hiding this comment.
I had a quick review of requireNativeComponent api, It looks like 2 last props are not used...
Did you check on which react-native version it has been removed ?
I think this can be merged rapidly. I just merge your previous small Prs
Thanks you
There was a problem hiding this comment.
According to facebook/react-native#28351 (comment), requireNativeComponent recieves only one argument since react-native@0.56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are working on fabric support for video. This is the first one
Describe the changes
According to facebook/react-native#28351 (comment),
requireNativeComponentrecieves only one argument since react-native@0.56According to https://github.com/facebook/react-native/tree/v0.69.4/Libraries/Components/Switch, native only properties are declared in
<ComponentName>NativeComponent.js, e.g.on,enabledandtrackTintColor