Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed JS Syntax error @ Video.js #3183

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Fixed JS Syntax error @ Video.js #3183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e7737d
Fixed javascript syntax error
atultiwaree Jul 26, 2023
9816ee1
Fixed javascript syntax error
atultiwaree Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
## Changelog



### Version 6.0.0-alpha.6
- Feature: Video range support [#3030](https://github.com/react-native-video/react-native-video/pull/3030)
- iOS: remove undocumented `currentTime` property [#3064](https://github.com/react-native-video/react-native-video/pull/3064)
- iOS: make sure that the audio in ads is muted when the player is muted. [#3068](https://github.com/react-native-video/react-native-video/pull/3077)
- iOS: make IMA build optionnal
- Android: Fixed syntax error [#3182](https://github.com/react-native-video/react-native-video/issues/3182)

### Version 6.0.0-alpha.5

Expand Down
2 changes: 1 addition & 1 deletion Video.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
},
});

const { VideoDecoderProperties } = NativeModules

Check warning on line 17 in Video.js

View workflow job for this annotation

GitHub Actions / build 

Missing semicolon
export { TextTrackType, FilterType, DRMType, VideoDecoderProperties }

Check warning on line 18 in Video.js

View workflow job for this annotation

GitHub Actions / build 

Missing semicolon

export default class Video extends Component {

Expand Down Expand Up @@ -77,7 +77,7 @@
this.setNativeProps({ fullscreen: false });
};

save = async (options?) => {
save = async (options) => {
return await NativeModules.VideoManager.save(options, findNodeHandle(this._root));
}

Expand Down Expand Up @@ -343,7 +343,7 @@
patchVer: source.patchVer || 0,
requestHeaders: source.headers ? this.stringsOnlyObject(source.headers) : {},
startTime: source.startTime || 0,
endTime: source.endTime

Check warning on line 346 in Video.js

View workflow job for this annotation

GitHub Actions / build 

Missing trailing comma
},
onVideoLoadStart: this._onLoadStart,
onVideoPlaybackStateChanged: this._onPlaybackStateChanged,
Expand Down
Loading