-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): add onBandwidthUpdate event #3331
feat(ios): add onBandwidthUpdate event #3331
Conversation
export type OnBandwidthUpdateData = Readonly< | ||
| { | ||
bitrate: number; | ||
width: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here width?: number;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But here i would like to leave it like this, it will be easier for user - if width is not null it means that height is also not null. Correct me if I am wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, no problem, and yes you are right, if wifth is ull height is null also
Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com>
Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com>
Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com>
Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com>
1 small additional clean needed, sorry :) |
merged for alpha.10 ticket: #1726 |
Summary
Add onBandwidthUpdate event
backport of #1745
Test plan