Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): fixes where Android's muted prop behavior differs from iOS #3339

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix(android): fixes where Android's muted prop behavior differs from iOS #3339

merged 1 commit into from
Nov 8, 2023

Conversation

YangJonghun
Copy link
Collaborator

Update the changelog

fix(android): fixes where Android's muted prop behavior differs from iOS

Provide an example of how to test the change

      <Video
        source={{
          uri: 'any valid url',
        }}
        muted
      />

Describe the changes

When Video Component mount with muted prop, it's behavior is different on Android and iOS

  • iOS
    play with no sound
  • Android
    play with sound

This PR makes Android behave like iOS

@freeboub freeboub merged commit 8fbdc28 into TheWidlarzGroup:master Nov 8, 2023
1 check passed
@YangJonghun YangJonghun deleted the fix/sync-muted-behavior branch November 8, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeboub freeboub freeboub approved these changes

@KrzysztofMoch KrzysztofMoch KrzysztofMoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YangJonghun @freeboub @KrzysztofMoch