Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): ensure duration available when playing live #3710

Merged
merged 7 commits into from
Apr 25, 2024
Merged

fix(ios): ensure duration available when playing live #3710

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
417bd7a
fix(ts): onPlaybackRateChangeData was not correctly typed
freeboub Apr 3, 2024
85fb438
Merge branch 'master' of github.com:react-native-video/react-native-v…
freeboub Apr 5, 2024
52b8ec1
fix: ensure tracks are well displayed in the sample
freeboub Apr 6, 2024
5ca679d
Merge branch 'master' of github.com:react-native-video/react-native-v…
freeboub Apr 16, 2024
39ac06d
Merge branch 'master' of github.com:react-native-video/react-native-v…
freeboub Apr 21, 2024
b92954a
Merge branch 'master' of github.com:react-native-video/react-native-v…
freeboub Apr 24, 2024
538137e
fix(ios): ensure duration is correct when starting a live playback
freeboub Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ios/Video/RCTVideo.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1281,8 +1281,13 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH
guard let _playerItem else { return }
var duration = Float(CMTimeGetSeconds(_playerItem.asset.duration))

if duration.isNaN {
duration = 0.0
if duration.isNaN || duration == 0 {
// This is a safety check for live video.
// AVPlayer report a 0 duration
duration = RCTVideoUtils.calculateSeekableDuration(_player).floatValue
if duration.isNaN {
duration = 0
}
}

var width: Float?
Expand Down
Loading