Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: avoid crash when setting index to 0 to tracks selection #3721

Merged
merged 8 commits into from
Apr 30, 2024
Merged

Fix: avoid crash when setting index to 0 to tracks selection #3721

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
417bd7a
fix(ts): onPlaybackRateChangeData was not correctly typed
freeboub Apr 3, 2024
85fb438
Merge branch 'master' of github.com:react-native-video/react-native-v…
freeboub Apr 5, 2024
52b8ec1
fix: ensure tracks are well displayed in the sample
freeboub Apr 6, 2024
5ca679d
Merge branch 'master' of github.com:react-native-video/react-native-v…
freeboub Apr 16, 2024
39ac06d
Merge branch 'master' of github.com:react-native-video/react-native-v…
freeboub Apr 21, 2024
b92954a
Merge branch 'master' of github.com:react-native-video/react-native-v…
freeboub Apr 24, 2024
2019395
Merge branch 'master' of github.com:react-native-video/react-native-v…
freeboub Apr 29, 2024
0fefebb
fix: avoid crash when setting invalid selected track or index 0
freeboub Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/Video.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,27 +193,30 @@ const Video = forwardRef<VideoRef, ReactVideoProps>(
if (!selectedTextTrack) {
return;
}
const value = selectedTextTrack.value
? `${selectedTextTrack.value}`
: undefined;

const type = typeof selectedTextTrack.value;
if (type !== 'number' && type !== 'string') {
console.log('invalid type provided to selectedTextTrack');
return;
}
return {
type: selectedTextTrack?.type,
value,
value: `${selectedTextTrack.value}`,
};
}, [selectedTextTrack]);

const _selectedAudioTrack = useMemo(() => {
if (!selectedAudioTrack) {
return;
}
const value = selectedAudioTrack.value
? `${selectedAudioTrack.value}`
: undefined;
const type = typeof selectedAudioTrack.value;
if (type !== 'number' && type !== 'string') {
console.log('invalid type provided to selectedAudioTrack');
return;
}

return {
type: selectedAudioTrack?.type,
value,
value: `${selectedAudioTrack.value}`,
};
}, [selectedAudioTrack]);

Expand Down
Loading