-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(android): avoid video resizing flickering #3751
Fix(android): avoid video resizing flickering #3751
Conversation
…oplayerView code size
…ideo # Conflicts: # android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java # src/Video.tsx
It is still possible to reproduce flickering. |
Thank you for the feedback, I didn't focus on selectedVideoTrack, but it is my plan soon ! :) |
…fix/avoidVideoResizingFlickering # Conflicts: # .github/ISSUE_TEMPLATE/bug-report.yml
Lets merge, @freeboub I will leave you fixing selectedVideoTrack case |
Yes, it was fixed in v6.0.0-rc.2. |
Summary
resize video View when we receive the list of video tracks instead of resizing it when the video is displayed
Motivation
Fix video flickering when starting playback: #3740 and #3653
Changes
resize video View when we receive the list of video tracks instead of resizing it when the video is displayed
Test plan
can be tested with the sample app