Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tvos): fix tv os build and sample #3785

Merged
merged 12 commits into from
May 20, 2024
Merged

fix(tvos): fix tv os build and sample #3785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d3fc4fd
perf: ensure we do not provide callback to native if no callback prov…
freeboub May 5, 2024
e1da32d
chore: rework bufferConfig to make it more generic and reduce ReactEx…
freeboub May 6, 2024
df3da43
Merge branch 'master' of github.com:react-native-video/react-native-v…
freeboub May 8, 2024
0f33ad1
chore: improve issue template
freeboub May 8, 2024
17f2385
Merge branch 'TheWidlarzGroup:master' into master
freeboub May 10, 2024
1066898
fix(android): avoid video view flickering at playback startup
freeboub May 10, 2024
485f867
Merge branch 'master' of github.com:react-native-video/react-native-v…
freeboub May 11, 2024
a5e10a3
Merge branch 'master' of github.com:freeboub/react-native-video into …
freeboub May 11, 2024
9ce1d95
Merge branch 'master' of github.com:react-native-video/react-native-v…
freeboub May 15, 2024
e34d8fe
chore: fix tvOS supported platform
freeboub May 16, 2024
7a2e867
chore: fix tvOS build
freeboub May 16, 2024
bb28139
chore: update project tvos configuration
freeboub May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions examples/exampletvOS/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ production = ENV["PRODUCTION"] == "1"

target 'exampletvOS' do

platform :ios, min_ios_version_supported
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrzysztofMoch I think we need to document this point also !
Would that fix be better ? #3737 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am also thinking about adding this info to README (that min ios version is 13) and to upgrade helper

platform :ios, '13.0'

config = use_native_modules!

Expand Down Expand Up @@ -51,7 +51,8 @@ end

target 'exampletvOS-tvOS' do

platform :tvos, min_ios_version_supported
platform :tvos, '13.0'


config = use_native_modules!

Expand Down
14 changes: 9 additions & 5 deletions examples/exampletvOS/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,9 +316,13 @@ PODS:
- React-jsinspector (0.71.12-0)
- React-logger (0.71.12-0):
- glog
- react-native-video (6.0.0-beta.6):
- react-native-video (6.0.0):
- RCT-Folly (= 2021.07.22.00)
- React-Core
- react-native-video/Video (= 6.0.0)
- react-native-video/Video (6.0.0):
- RCT-Folly (= 2021.07.22.00)
- React-Core
- react-native-video/Video (= 6.0.0-beta.6)
- React-perflogger (0.71.12-0)
- React-RCTActionSheet (0.71.12-0):
- React-Core/RCTActionSheetHeaders (= 0.71.12-0)
Expand Down Expand Up @@ -588,7 +592,7 @@ SPEC CHECKSUMS:
React-jsiexecutor: 0c8c5e8b2171be52295f59097923babf84d1cf66
React-jsinspector: f8e6919523047a9bd1270ade75b4eca0108963b4
React-logger: 16c56636d4209cc204d06c5ba347cee21b960012
react-native-video: 98040e05dace82fbbe8709cf42fd4496b0aed744
react-native-video: fc60911540a69935cc7950829163f6f41259cb0d
React-perflogger: 355109dc9d6f34e35bc35dabb32310f8ed2d29a2
React-RCTActionSheet: 9d1be4d43972f2aae4b31d9e53ffb030115fa445
React-RCTAnimation: aab7e1ecd325db67e1f2a947d85a52adf86594b7
Expand All @@ -605,6 +609,6 @@ SPEC CHECKSUMS:
Yoga: 8b8c06e142662150974d1c70b4c5ffb08eb468db
YogaKit: 1e22bf2228b3a5ac8cc88965153061ae92c494b5

PODFILE CHECKSUM: 49dad183688257f9360c15d54e77f8de0f8048f7
PODFILE CHECKSUM: 26d254806a611a4bc6b6c39cff790dd08f770ccf

COCOAPODS: 1.13.0
COCOAPODS: 1.15.2
Loading
Loading