fix(android): allow notification tap to foreground app #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses #3811 |
|
FYI @freeboub using |
YangJonghun
reviewed
May 23, 2024
|
paulrinaldi
force-pushed
the
3881
branch
7 times, most recently
from
047af84 to
f32ffcb
Compare
3881-final-demo.movCleaned up the code and revised the design. |
freeboub
requested changes
May 23, 2024
android/src/main/java/com/brentvatne/exoplayer/VideoPlaybackService.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/brentvatne/exoplayer/VideoPlaybackService.kt
Outdated
Show resolved
Hide resolved
paulrinaldi
force-pushed
the
3881
branch
2 times, most recently
from
5619fa8 to
483f3fa
Compare
freeboub
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the documentation
N/A
Provide an example of how to test the change
https://github.com/TheWidlarzGroup/react-native-video/assets/107127397/a4f1e82d-47cb-439f-9998-665fb2f70714
set
showNotificationControls={true}on video playerFocus the PR on only one area
N/A
Describe the changes
Passes the activity which spawns the notification service to the service so that the service can set the intent to foreground that service when clicked.
Summary
Enable tapping on notification to foreground the original app.
Motivation
Feature parity between iOS and Android. General expectation of tapping a notification.
Changes
set the pending intent for setSessionActivity on mediaSession creation in Android.
Test plan
N/A
Other Notes
Address #3881
We might want to import android.app.Activity instead of using fully qualified type to maintain codestyle.
We might want to pass this in a different way... this is a first attempt that works.
Need to clean this up still