Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): show controls in notification on older androids #3886

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

KrzysztofMoch
Copy link
Member

Summary

On older android media session is not automatically adding controls to notification (see bellow)
image

This PR address this issue

Motivation

Fix issue with missing controls in notification on older androids

Changes

  • refactor notification api to support older devices

Test plan

Tested on various emulators with different android version (android 9, 12, 13, 14)

Copy link
Collaborator

@freeboub freeboub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, else, it looks good to me

@KrzysztofMoch KrzysztofMoch merged commit 098a754 into master Jun 12, 2024
5 checks passed
@KrzysztofMoch KrzysztofMoch deleted the fix/android-missing-notification-controls branch June 17, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants