chore(example/basic): refactor code to follow best react-native practices #3990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moskalakamil
force-pushed
the
refactor/example
branch
from
0137696
to
c7fe83d
Compare
KrzysztofMoch
changed the title
KrzysztofMoch
approved these changes
Jul 11, 2024
freeboub
requested changes
Jul 11, 2024
|
And you have conflict now ... |
moskalakamil
force-pushed
the
refactor/example
branch
2 times, most recently
from
c7fe83d
to
2b58ede
Compare
moskalakamil
force-pushed
the
refactor/example
branch
from
2b58ede
to
773b789
Compare
|
@freeboub resolved conflicts 👍 |
freeboub
approved these changes
Jul 15, 2024
|
OK for me, I just fix the conflict, should be OK to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update example code
Motivation
Update rnv basic example code to follow best rn practices
Changes
Test plan