Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expo plugin export #3992

Merged

Conversation

KrzysztofMoch
Copy link
Member

Summary

Fix expo plugin export via adding missing files to flies in package.json

Also fixed docs metadata as "expo" section don't display now

Motivation

Add missing file in builded library

Changes

  • add app.plugin.js to files in package.json
  • fix docs metadata
  • update docs link in docs config

Test plan

@freeboub
Copy link
Collaborator

It would sense to build a 6.4.1 with these fixes ?

@KrzysztofMoch
Copy link
Member Author

Yeah, I will do it tomorrow

@KrzysztofMoch KrzysztofMoch merged commit de8ade0 into TheWidlarzGroup:master Jul 11, 2024
3 checks passed
@KrzysztofMoch KrzysztofMoch deleted the fix/expo-plugin-export branch July 12, 2024 07:54
moskalakamil pushed a commit to moskalakamil/react-native-video that referenced this pull request Jul 12, 2024
moskalakamil pushed a commit to moskalakamil/react-native-video that referenced this pull request Jul 17, 2024
@freeboub
Copy link
Collaborator

@KrzysztofMoch I am trying to configure the sample with expo configuration, It say that the plugin is not found:

I have just added config in app.json

PluginError: Failed to resolve plugin for module "react-native-video" relative to "/Users/olivier/openSource/react-native-video/examples/basic"

Can it be this missing file issue ? https://docs.expo.dev/modules/module-config/

@KrzysztofMoch
Copy link
Member Author

@freeboub I remember that when I was creating this plugin I wanted to add this to example but I couldn't do it, but now not sure why... I think I was something about building plugin - I bet if you try use plugin in project with RNV from npm it will work

Can it be this missing file issue ? https://docs.expo.dev/modules/module-config/

probably this won't change anything as this file is for expo modules not (bare) react-native modules

@freeboub
Copy link
Collaborator

@freeboub I remember that when I was creating this plugin I wanted to add this to example but I couldn't do it, but now not sure why... I think I was something about building plugin - I bet if you try use plugin in project with RNV from npm it will work

Can it be this missing file issue ? https://docs.expo.dev/modules/module-config/

probably this won't change anything as this file is for expo modules not (bare) react-native modules

Ok thanks, I will try with npm version. I think this is a bug or a limitation in expo ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants