-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: expo plugin export #3992
fix: expo plugin export #3992
Conversation
It would sense to build a 6.4.1 with these fixes ? |
Yeah, I will do it tomorrow |
@KrzysztofMoch I am trying to configure the sample with expo configuration, It say that the plugin is not found: I have just added config in app.json PluginError: Failed to resolve plugin for module "react-native-video" relative to "/Users/olivier/openSource/react-native-video/examples/basic" Can it be this missing file issue ? https://docs.expo.dev/modules/module-config/ |
@freeboub I remember that when I was creating this plugin I wanted to add this to example but I couldn't do it, but now not sure why... I think I was something about building plugin - I bet if you try use plugin in project with RNV from npm it will work
probably this won't change anything as this file is for expo modules not (bare) react-native modules |
Ok thanks, I will try with npm version. I think this is a bug or a limitation in expo ... |
Summary
Fix expo plugin export via adding missing files to flies in
package.json
Also fixed docs metadata as "expo" section don't display now
Motivation
Add missing file in builded library
Changes
app.plugin.js
tofiles
inpackage.json
Test plan