Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): index of the selected track #4012

Merged

Conversation

seyedmostafahasani
Copy link
Collaborator

Summary

Motivation

Changes

Test plan

@freeboub
Copy link
Collaborator

@seyedmostafahasani can you please describe your change please? Is it solving issue with specific content?

@seyedmostafahasani
Copy link
Collaborator Author

@freeboub in the sample app, we show a list of videos that a user can switch between. Before this change, the selected tracker was always the first item because trackIndex always passed 0. With this change, the correct selected track is always passed. Previously, if you ran the sample app, you could not see the subtitle for track BigBugBunny sideLoaded subtitles(last track in the sample app). However, now you can see it because the selected track is correct.

@KrzysztofMoch KrzysztofMoch merged commit fb1d6bd into TheWidlarzGroup:master Jul 24, 2024
3 checks passed
@seyedmostafahasani seyedmostafahasani deleted the fix(android)/trackId branch July 24, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants