fix(ios): crash on source change after coming back from background #4074
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This works around the crash on source change, if the app was previously put in the background. The crash occurs on iOS >= 16 and I blame apple for this 😅. They seem to be adding some observer logic on the player instance, causing it to explode in mentioned scenario.
This might not be a super sophisticated solution, perhaps there is a better more granular way to handle this, but on another hand it's simple and works well.
Motivation
Fix for #3900
Changes
Test plan
Author of the issue provided a crash demo app.
I was able to run it with:
Once succesfuly ran: