Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VisionOS): do not access to isExternalPlaybackActive on VisionOS #4109

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

freeboub
Copy link
Collaborator

Summary

ensure we don't access to isExternalPlaybackActive on VisionOS

Motivation

Fix: #4079

Changes

refactor access to the flag to have only 1 ifdef

Test plan

N/A

@KrzysztofMoch KrzysztofMoch self-requested a review August 22, 2024 09:26
Copy link
Member

@KrzysztofMoch KrzysztofMoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix!

@freeboub
Copy link
Collaborator Author

@KrzysztofMoch I just tested on the emulator, it works fine !

@KrzysztofMoch
Copy link
Member

So let's merge

@freeboub freeboub merged commit 0576eac into master Aug 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: isExternalPlaybackActive' is unavailable in visionOS
3 participants