-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ads localize #4113
feat: add ads localize #4113
Conversation
Looks good !
|
And please check why the build without ads is ko ! :) |
I will add the instance to imaSdkFactory, and the function setImaSdkSettings to imaLoader that's probably it. |
android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.kt
Show resolved
Hide resolved
Thanks for PR! I'm just wondering, is it possible to create a 'adConfig' prop with all customization for ads? maybe it's similar logic and then we can pass all of the settings for ads |
I agree, but we should not block this PR For that point. |
From IMA doc: |
I just put one proposal for doc, I let you approve and integrate it. |
Hey, I don't mind doing this prop, and move this prop there. I already implement that on ios. i need to work on android and I will open pr for it :D |
Language correction Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com>
@guyhguy25 up to you, I will wait for @KrzysztofMoch next week to merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is Okay to merge for me
OK, let's merge as is. Don't hesitate to reopen another PR for refactor ! @guyhguy25 |
Add a localize for Advertisements.
Summary
Added props to change the ima language settings.
Motivation
I have been asked to make the "skip" and "Read more" in different languages.
I tried to ask in Discord if someone knows how to add it, but I didn't see anyone who asked for this feature, although if someone using this library for production he needs it, so I did it.
I created that for my company so it did not waste my time, if you like it you more than welcome to take it.
Changes
add prop: adLanguage
add docs for it.
Java:
add ImaSdkFactory & ImaSdkSettings to the google ads api
Swift:
see pr diff.
Test plan
add adTagUrl and then add adLanguage for example: "fr".
and that's it.