fix(expo-plugin): add check for existing service in AndroidManifest for notification controls #4172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminmeshk
changed the title
freeboub
approved these changes
Sep 14, 2024
|
Looks easy :) Thank you for the patch ! |
seyedmostafahasani
approved these changes
Sep 14, 2024
Co-authored-by: Seyed Mostafa Hasani <seyedmostafahassani@gmail.com>
|
@aminmeshk |
You miss the spaces in your proposal... I commit it without thinking of it 🙄 |
|
I fixed the spaces |
aminmeshk
deleted the
fix/expo-plugin-notification-service-duplicate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a minor issue with Expo Config Plugins (the one related to notification controls) that caused having duplicate
<service>tags in the generatedAndroidManifest.xmlfile when running non-cleaningnpx expo prebuildmultiple times.Motivation
Fix this issue: #4167
Changes
I added a check in
withNotificationControls.tsfile for existing service in to avoid having duplicate code inAndroidManifest.xml.Test plan