feat(android): enable to hide specific controls #4183
Conversation
moskalakamil
force-pushed
the
feat/controllers-customization
branch
from
43c0240
to
2c05358
Compare
| if (controlsConfig.getHidePlayPause()) { | ||
| playPauseControlContainer.setAlpha(0); | ||
|
|
||
| playButton.setClickable(false); | ||
| pauseButton.setClickable(false); | ||
| } else { | ||
| playPauseControlContainer.setAlpha(1.0f); | ||
|
|
||
| playButton.setClickable(true); | ||
| pauseButton.setClickable(true); | ||
| } | ||
|
|
||
| final ImageButton forwardButton = playerControlView.findViewById(R.id.exo_ffwd); | ||
| if (controlsConfig.getHideForward()) { | ||
| forwardButton.setImageAlpha(0); | ||
| forwardButton.setClickable(false); | ||
| } else { | ||
| forwardButton.setImageAlpha(255); | ||
| forwardButton.setClickable(true); | ||
| } | ||
|
|
||
| final ImageButton rewindButton = playerControlView.findViewById(R.id.exo_rew); | ||
| if (controlsConfig.getHideRewind()) { | ||
| rewindButton.setImageAlpha(0); | ||
| rewindButton.setClickable(false); | ||
| } else { | ||
| rewindButton.setImageAlpha(255); | ||
| rewindButton.setClickable(true); | ||
| } | ||
|
|
||
| final ImageButton nextButton = playerControlView.findViewById(R.id.exo_next); | ||
| if (controlsConfig.getHideNext()) { | ||
| nextButton.setClickable(false); | ||
| nextButton.setImageAlpha(0); | ||
| } else { | ||
| nextButton.setImageAlpha(255); | ||
| nextButton.setClickable(true); | ||
| } | ||
|
|
||
| final ImageButton previousButton = playerControlView.findViewById(R.id.exo_prev); | ||
| if (controlsConfig.getHidePrevious()) { | ||
| previousButton.setImageAlpha(0); | ||
| previousButton.setClickable(false); | ||
| } else { | ||
| previousButton.setImageAlpha(255); | ||
| previousButton.setClickable(true); | ||
| } |
There was a problem hiding this comment.
setVisibility doesn't work correctly for these items
moskalakamil
requested review from
seyedmostafahasani,
freeboub and
KrzysztofMoch
| hidePlayPause?: WithDefault<boolean, false>; | ||
| hideForward?: WithDefault<boolean, false>; | ||
| hideRewind?: WithDefault<boolean, false>; | ||
| hideNext?: WithDefault<boolean, false>; |
There was a problem hiding this comment.
I wonder if the next and previous buttons should be hidden by default, they are always displayed but never usable 🤔 @KrzysztofMoch @seyedmostafahasani what are your point of views ?
There was a problem hiding this comment.
I agree with hiding the previous and next buttons by default. However, I don't understand why we would allow the user to hide the play and pause buttons.
There was a problem hiding this comment.
Background videos - it is just an option
I wonder if the next and previous buttons should be hidden by default
I agree we can hide them by default
There was a problem hiding this comment.
@seyedmostafahasani depending of UI requierements, it make sense (live content, or not pausable video , why not :) )
@moskalakamil can you just change hideNext and hidePrevious to true
There was a problem hiding this comment.
@freeboub
Thank you for the explanation.
@moskalakamil
Thank you for creating this PR.
Summary
Create new feature which allow user to hide specific controls on android devices
Closes #3193
Motivation
#3193
Changes
update function to allow hide more controls
Test plan