feat(android): add live video label #4190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeboub
requested changes
Sep 22, 2024
android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
Outdated
Show resolved
Hide resolved
freeboub
reviewed
Sep 26, 2024
android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
Outdated
Show resolved
Hide resolved
seyedmostafahasani
changed the title
freeboub
reviewed
Sep 28, 2024
android/src/main/java/com/brentvatne/common/api/ControlsConfig.kt
Outdated
Show resolved
Hide resolved
freeboub
reviewed
Sep 28, 2024
android/src/main/java/com/brentvatne/common/api/ControlsConfig.kt
Outdated
Show resolved
Hide resolved
freeboub
reviewed
Sep 28, 2024
android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
Outdated
Show resolved
Hide resolved
|
One more remark and after I think we are good ! |
|
and you forgot to add the new field in the documentation ! |
|
You're right. |
|
@freeboub |
android/src/main/java/com/brentvatne/common/api/ControlsConfig.kt
Outdated
Show resolved
Hide resolved
KrzysztofMoch
approved these changes
Sep 29, 2024
|
@seyedmostafahasani there are some conflict due to another pr merged. previousButton.setImageAlpha(0);
previousButton.setClickable(false);Thank you |
# Conflicts: # android/src/main/java/com/brentvatne/common/api/ControlsConfig.kt # android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java # docs/pages/component/props.mdx # src/specs/VideoNativeComponent.ts # src/types/video.ts
@freeboub |
freeboub
approved these changes
Oct 1, 2024
sharnik
pushed a commit
to brains-and-beards/react-native-video
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Display a
Livelabel for live videos.Motivation
This allows the user to easily identify whether the video is live.
Changes
Test plan
Play a live video in the sample app to verify the label appears correctly.