Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): sideloaded subtitles #4232

Merged

Conversation

KrzysztofMoch
Copy link
Member

@KrzysztofMoch KrzysztofMoch commented Oct 11, 2024

Summary

Fix sideload subtitles

Motivation

Fix sideload subtitles that broke after media3 update

fix #4189

Test plan

Run "BigBugBunny sideLoaded subtitles" on example app

@freeboub
Copy link
Collaborator

Looks good, Thank you !

@KrzysztofMoch KrzysztofMoch merged commit 352dfbb into TheWidlarzGroup:master Oct 11, 2024
3 checks passed
@KrzysztofMoch KrzysztofMoch deleted the fix/android-sideload branch October 11, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Throws Error when external subtitle is loaded
2 participants