Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hiding poster #4308

Merged
merged 4 commits into from
Dec 1, 2024
Merged

fix: hiding poster #4308

merged 4 commits into from
Dec 1, 2024

Conversation

moskalakamil
Copy link
Member

@moskalakamil moskalakamil commented Nov 27, 2024

Summary

remove display none video style when poster is visible

Motivation

display none was triggering issues on new architecture, because native view was invisible and didn't trigger _onReadyForDisplay and some others events

Changes

Test plan

@moskalakamil moskalakamil marked this pull request as draft November 27, 2024 12:49
@moskalakamil moskalakamil marked this pull request as ready for review November 27, 2024 14:12
@KrzysztofMoch KrzysztofMoch merged commit 621a802 into master Dec 1, 2024
4 checks passed
@KrzysztofMoch KrzysztofMoch deleted the moskalakamil-patch-1 branch December 1, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants