Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExoPlayer] Load new source if it is different #502

Merged

Conversation

AndrewJack
Copy link
Contributor

@AndrewJack AndrewJack commented Feb 21, 2017

Fixes: #481

Try with these test streams

const YT_GLASS_SOURCE = { uri: 'http://www.youtube.com/api/manifest/dash/id/bf5bb2419360daf1/source/youtube?as=fmp4_audio_clear,fmp4_sd_hd_clear&sparams=ip,ipbits,expire,source,id,as&ip=0.0.0.0&ipbits=0&expire=19000000000&signature=51AF5F39AB0CEC3E5497CD9C900EBFEAECCCB5C7.8506521BFC350652163895D4C26DEE124209AA9E&key=ik0', type: 'mpd' };
const YT_GPLAY_SOURCE = { uri: 'http://www.youtube.com/api/manifest/dash/id/3aa39fa2cc27967f/source/youtube?as=fmp4_audio_clear,fmp4_sd_hd_clear&sparams=ip,ipbits,expire,source,id,as&ip=0.0.0.0&ipbits=0&expire=19000000000&signature=A2716F75795F5D2AF0E88962FFCD10DB79384F29.84308FF04844498CE6FBCE4731507882B8307798&key=ik0', type: 'mpd' };

@AndrewJack AndrewJack changed the title Load new source if it is different [ExoPlayer] Load new source if it is different Feb 21, 2017
@AndrewJack AndrewJack mentioned this pull request Mar 17, 2017
@mattapperson mattapperson merged commit 79a9ea5 into TheWidlarzGroup:master Mar 21, 2017
@darbaoui darbaoui mentioned this pull request May 4, 2017
@darbaoui
Copy link

@AndrewJack
this update #502 cannot allow to play audio in background.
--back to home not audio playing in background
-- return to the app again, audio continue to playing

mattvot pushed a commit to calvium/react-native-video that referenced this pull request May 12, 2017
* master:
  Added flag for background mode (TheWidlarzGroup#563)
  issue 310 - Added a new property, ignoreSilentSwitch.  (TheWidlarzGroup#403)
  Add progressUpdateInterval to android-exoplayer (TheWidlarzGroup#540)
  Initial WPF Support (TheWidlarzGroup#385)
  added progressUpdateInterval to Android (TheWidlarzGroup#512)
  load new source if it is different (TheWidlarzGroup#502)
  Pausing progress if it was playing and the stating again (TheWidlarzGroup#526)
  bump android dependencies (TheWidlarzGroup#524)
  Update ExoPlayer to r2.2.0 (TheWidlarzGroup#505)
  Update readme (TheWidlarzGroup#497)
  [Android] App crash when unmounting video (TheWidlarzGroup#533)
  Fix/494 (TheWidlarzGroup#537)
  fix(RCTVideo.m): Fixed status bar disappearing issue
@onehassan
Copy link

How can I apply the fix in my react-native project, i tried to replicate the changes in the source code of the exoplayer node-module but the issue still persists?

@onehassan
Copy link

I think I found the issue, I have a background Video on the Login screen and another instance in another screen that I push on top with a stack navigator, It seems that the first instance of the video overlaps the other instance. How can I handle such scenario?

@renay007
Copy link

I am having the same issue on Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants