Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added optional request headers for remote assests (android & ios) #805

Merged
merged 15 commits into from
Jun 25, 2018
Merged

added optional request headers for remote assests (android & ios) #805

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
270fdfb
added optional request headers for remote assests (android & ios)
emrahdk Oct 2, 2017
57a16b2
stringsOnlyObject does typechecking before coercion to string
emrahdk Jan 13, 2018
db1d83b
constants renamed to requestheader
emrahdk Jan 13, 2018
5c8e1bd
ensuring datasource is build with headers
emrahdk Jan 15, 2018
12f93b5
null pointer
emrahdk Jan 15, 2018
fefbe80
Merge branch 'master' into master
cobarx May 29, 2018
623b562
resolving conflicts
emrahdk Jun 9, 2018
2d89a3f
Merge branch 'master' into master
emrahdk Jun 9, 2018
f340025
respecting cookies when opting in for headers (ios)
emrahdk Jun 9, 2018
49cd5b6
passing headers to setDataSource when network video
emrahdk Jun 9, 2018
6cd7dfe
fix syntax errors
emrahdk Jun 11, 2018
2649242
Remove duplicate outdated stringsOnlyObject implementation
cobarx Jun 23, 2018
c67dd7b
Merge branch 'master' into master
cobarx Jun 23, 2018
bb2b3eb
Handle converting maps that are null or empty
cobarx Jun 23, 2018
448e57b
Add note about IOException when using bigger setDataSource call
cobarx Jun 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/src/main/java/com/brentvatne/react/ReactVideoView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ public void setSrc(final String uriString, final String type, final boolean isNe
headers.putAll(toStringMap(mRequestHeaders));
}

setDataSource(uriString);
setDataSource(mThemedReactContext, parsedUrl, headers);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In master (of the main repo) no headers are being passed to setDataSource. Even though the headers HashMap is being created (lines 247-251) and the cookies are added to it.

Is it me or was the headers never used?

Luckily setDataSource had an overload that accepted headers which I could pass them to.

} else if (isAsset) {
if (uriString.startsWith("content://")) {
Uri parsedUrl = Uri.parse(uriString);
Expand Down