Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14.0 stock picking report cmr #1

Open
wants to merge 5 commits into
base: 14.0
Choose a base branch
from

Conversation

ntsirintanis
Copy link

No description provided.

AshishHirapara and others added 2 commits January 17, 2025 13:40
initial commit

This module allows the printing of the CMR report from a given delivery note.
Copy link

@gjotten gjotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ntsirintanis AFAICS we're missing package_type for item 8 in the report, where we need to render the display name of the selection field.

Otherwise, this seems to go well, but @thomaspaulb should also review

Comment on lines 628 to 636
<t
t-if="o.shipping_weight"
>
<div
class="text-bigger text-dark mt-1 ml-2"
>
<span
t-field="o.shipping_weight"
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ntsirintanis make it o.weight rather - I don't see shipping_weight being filled, on second viewing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipping_weight is basically computed from package weight. Have you checked if the weight field in packages if filled?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's supposed to be computed, but I didn't see it happen. Maybe they have broken something in their setup.

image

class="text-bigger text-dark mt-1 ml-2"
>
<span
t-esc="', '.join(o.move_line_ids.mapped('result_package_id.packaging_id.name'))"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gjotten this is basically package_type

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm that's some ways away from strictly package_type on the picking - not sure about this one either, could again be something to do with their setup; @thomaspaulb

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see now. stock.picking.package_type appears to be a customer specific field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants