Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting an inventory item will show success message even if it fails #4147

Closed
jniles opened this issue Jan 29, 2020 · 1 comment · Fixed by #4149
Closed

Deleting an inventory item will show success message even if it fails #4147

jniles opened this issue Jan 29, 2020 · 1 comment · Fixed by #4149
Assignees
@jniles
Labels
Bug in progress

Comments

@jniles
Copy link
Collaborator

jniles commented Jan 29, 2020

This is a pretty serious bug. If you try to delete an inventory item, it will show a green "success" message, even if it fails. See below:

NmwyLDFGdL
@jniles jniles added the Bug label Jan 29, 2020
@jniles
Copy link
Collaborator Author

jniles commented Jan 30, 2020

@kwilu claim

jniles added a commit to jniles/bhima that referenced this issue Jan 30, 2020
@jniles
fix(inventory): allow deletion from inventory
839970a 
This commit removes the foreign key constraints from the inventory_log
to allow deletion from the inventory.  It also fixes the http headers
sent twice error in the error handler.

Closes Third-Culture-Software#4147.
@jniles jniles mentioned this issue Jan 30, 2020
Merged
bors bot added a commit that referenced this issue Feb 3, 2020
@bors @jniles
Merge #4143 #4149
fc2db60 
4143: feat(reports): add file type detection r=jniles a=jniles

Adds file type detection to the reports archive page so that we are not
proposing to the user to print reports that are not printable (xlsx for
example).  It also adds features to provide the correct font awesome
icon depending on the extension to help a user determine which kind of
file they will be downloading.

**Example**
![RZoqUH5TAk](https://user-images.githubusercontent.com/896472/73257918-e899a400-41c4-11ea-9898-76bb6bd0a333.gif)


4149: fix(inventory): allow deletion from inventory r=jniles a=jniles

This commit removes the foreign key constraints from the inventory_log
to allow deletion from the inventory.  It also fixes the http headers
sent twice error in the error handler.

Closes #4147.

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
bors bot added a commit that referenced this issue Feb 3, 2020
@bors @jniles
Merge #4143 #4149
d621ee9 
4143: feat(reports): add file type detection r=jniles a=jniles

Adds file type detection to the reports archive page so that we are not
proposing to the user to print reports that are not printable (xlsx for
example).  It also adds features to provide the correct font awesome
icon depending on the extension to help a user determine which kind of
file they will be downloading.

**Example**
![RZoqUH5TAk](https://user-images.githubusercontent.com/896472/73257918-e899a400-41c4-11ea-9898-76bb6bd0a333.gif)


4149: fix(inventory): allow deletion from inventory r=jniles a=jniles

This commit removes the foreign key constraints from the inventory_log
to allow deletion from the inventory.  It also fixes the http headers
sent twice error in the error handler.

Closes #4147.

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
@bors bors bot closed this as completed in 789e1b6 Feb 3, 2020
@bors bors bot closed this as completed in #4149 Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(inventory): allow deletion from inventory jniles/bhima
2 participants
@jniles @kwilu