Feat: add barcode scan for invoice to stock movement #4145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the initial stock exit by scanning an invoice barcode. In addition to being able to attach a patient and/or an invoice, the user is now able to scan an invoice barcode to look up the invoice in question. TODO - the barcode scan does not template in the values for each inventory item like the bh-find-invoice component does.
Uses FilterParser on the /invoices/consumable API to allow us to search via invoice_uuid as well as a human readable invoiceReference.
jniles
force-pushed
the
feat-add-barcode-scan-for-invoice-to-stock-movement
branch
from
c240178
to
19e7472
Compare
Enhances the bhFindInvoice component to allow an external invoice uuid to set the internal invoice. This enhancement allows us to scan external barcodes and use the component to display the result of that scan. Closes Third-Culture-Software#3949.
jniles
force-pushed
the
feat-add-barcode-scan-for-invoice-to-stock-movement
branch
from
19e7472
to
bd387ad
Compare
|
bors r+ |
|
This PR was included in a batch with a merge conflict, it will be automatically retried |
2 similar comments
|
This PR was included in a batch with a merge conflict, it will be automatically retried |
|
This PR was included in a batch with a merge conflict, it will be automatically retried |
bors bot
added a commit
that referenced
this pull request
Feb 3, 2020
4145: Feat: add barcode scan for invoice to stock movement r=jniles a=jniles This PR implements stock exits via a barcode scan to link the patient and invoice. It was requested by our friends in Vanga. In order to make the barcode scan have the same behavior as manually searching, I implemented an `invoice-uuid` property on the `bh-find-invoice` component to allow the invoice to be set externally. This allows external components to pass in an invoice-uuid and the component to look it up and render it in the same presentation as if the user typed in the reference. Additionally, I also changed the server API for finding consumable items to take in either the `invoiceUuid` or the `invoiceReference`. This is what it looks like in action:  Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
jniles
deleted the
feat-add-barcode-scan-for-invoice-to-stock-movement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements stock exits via a barcode scan to link the patient and invoice. It was requested by our friends in Vanga.
In order to make the barcode scan have the same behavior as manually searching, I implemented an
invoice-uuidproperty on thebh-find-invoicecomponent to allow the invoice to be set externally. This allows external components to pass in an invoice-uuid and the component to look it up and render it in the same presentation as if the user typed in the reference.Additionally, I also changed the server API for finding consumable items to take in either the
invoiceUuidor theinvoiceReference.This is what it looks like in action: