(Feature) Current exchanged value presented on invoices #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jniles
reviewed
Nov 18, 2016
| @@ -66,6 +82,11 @@ function InvoiceRegistryController(Invoices, bhConstants, Notify, Session, util, | |||
| vm.loading = !vm.loading; | |||
| } | |||
|
|
|||
| Currencies.read() | |||
There was a problem hiding this comment.
This should have a Notify handler.
| @@ -65,7 +65,7 @@ | |||
| <tr> | |||
| <td>{{this.code}}</td> | |||
| <td>{{this.text}}</td> | |||
| <td class="text-right">{{currency this.transaction_price}}</td> | |||
| <td class="text-right">{{this.transaction_price}}</td> | |||
There was a problem hiding this comment.
Is this for precision reasons?
There was a problem hiding this comment.
This is to address #888
| <td colspan="2">{{{translate 'EXCHANGE.INVOICE_DISCLAIMER'}}}</td> | ||
| </tr> | ||
| <tr> | ||
| <td colspan="2">{{{translate 'EXCHANGE.SET_AS'}}} 1:{{exchange}} {{{translate 'EXCHANGE.ON'}}} {{dateFormat}}</td> |
There was a problem hiding this comment.
It would look nicer if you used the currency filter on the 1 here, I think.
|
Note: This closes #902. |
This commit adds required components and client side service infrastructure to specifiy which currency an invoice should be made to a patient in.
This commit updates the template and the controller for adding exchange rate values and an exchanged total to receipts.
This commit sets up the infrastructure for the receipt currency component. This component will provide an on update callback that updates the controller when the user has selected a new currency for the receipt. It will also cache the user's previous choice.
sfount
force-pushed
the
feature-franc-invoices
branch
from
e504038
to
6b91c84
Compare
jniles
approved these changes
Nov 27, 2016
| } | ||
| }); | ||
|
|
||
| ReceiptCurrencyController.$inject = ['CurrencyService', 'SessionService', 'AppCache', 'Store']; |
There was a problem hiding this comment.
Nice and clean component. 👍
|
|
||
|
|
||
| <div class="toolbar-item"> | ||
| <bh-receipt-currency |
There was a problem hiding this comment.
It's better practice to have close component tags, instead of having self-closing tags. On Chrome, our target, it isn't a problem ... but it's bad practice.
For reference, angular/angular.js#1953, angular/angular#5563 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds a value in the selected currency to patient invoices. It uses the valid exchange rate at the time of invoice.
If the enterprise currency is selected no exchange information is displayed.
Receipt currency selection (Invoice registry module)
Receipt displaying converted $:FC amount
The primary functionality is included in this pull request. Ideally to complete:
Add receipt currency selection component to patient invoice module to allow receipts to be fetched in FC as they are madeTo be designedFuture questions
Closes #888
Closes #902