Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add curl check of the local instance #16

Merged
merged 18 commits into from
Oct 15, 2024
Merged

Add curl check of the local instance #16

merged 18 commits into from
Oct 15, 2024

Conversation

hnykda
Copy link
Contributor

@hnykda hnykda commented May 25, 2023

No description provided.

@hnykda hnykda mentioned this pull request May 25, 2023
Closed
@hnykda
Copy link
Contributor Author

hnykda commented May 25, 2023 •
edited
Loading

@ThomDietrich WDYT so far? Something like this?

I was also thinking that a fancy way would be some kind of autodiscovery for beginners, e.g. using nmap, but that sounds too unreliable and probably not worth it.

ThomDietrich
ThomDietrich reviewed May 26, 2023
View reviewed changes
autossh/config.yaml Outdated Show resolved Hide resolved
ThomDietrich
ThomDietrich reviewed May 26, 2023
View reviewed changes
autossh/config.yaml Outdated Show resolved Hide resolved
ThomDietrich
ThomDietrich reviewed May 26, 2023
View reviewed changes
autossh/config.yaml Outdated Show resolved Hide resolved
ThomDietrich
ThomDietrich reviewed May 26, 2023
View reviewed changes
autossh/config.yaml Outdated Show resolved Hide resolved
ThomDietrich
ThomDietrich reviewed May 26, 2023
View reviewed changes
autossh/run.sh Outdated Show resolved Hide resolved
ThomDietrich
ThomDietrich reviewed May 26, 2023
View reviewed changes
autossh/run.sh Outdated Show resolved Hide resolved
@ThomDietrich
Copy link
Owner

Nice one! I've asked for a PR but didn't expect one within 24h :) Looks very good! I left a few comments.

hnykda and others added 6 commits May 26, 2023 19:41
@hnykda @ThomDietrich
add ip
f879084 
Co-authored-by: Thomas Dietrich <Thomas@Nurzen.de>
@hnykda @ThomDietrich
local ip optional
23dcb03 
Co-authored-by: Thomas Dietrich <Thomas@Nurzen.de>
@hnykda @ThomDietrich
local port optional
6d95435 
Co-authored-by: Thomas Dietrich <Thomas@Nurzen.de>
@hnykda
addressing PR comments
c7b9bb3
@hnykda
add docs
cafba74
@hnykda
default
c458d77
@hnykda hnykda marked this pull request as ready for review May 26, 2023 18:07
@hnykda hnykda requested a review from ThomDietrich May 26, 2023 18:07
@hnykda
Copy link
Contributor Author

hnykda commented May 26, 2023

Can you resolve pending comments if they are OK please?

@hnykda hnykda marked this pull request as draft May 26, 2023 18:09
@hnykda
Copy link
Contributor Author

hnykda commented May 26, 2023

FYI I haven't tested it yet, so keeping it in draft. Will try to test it when I am at home and can be sure I will not lock myself out :-D ...

Is changing https://github.com/hnykda/home-assistant-addons/blob/patch-1/repository.json#L2-L4 to something else, then adding it in https:///hassio/store as a new repo and then testing it enough?

@ThomDietrich
Copy link
Owner

Hey! Did you want to continue with this? I am looking forward to this improvement

@hnykda
Copy link
Contributor Author

hnykda commented Oct 29, 2023

Hey! I am sorry, I haven't managed to get back to it, unfortunately 😞 . Hm, can you take it from me or is it unlikely?

@ThomDietrich ThomDietrich marked this pull request as ready for review October 15, 2024 22:08
@ThomDietrich ThomDietrich merged commit e849335 into ThomDietrich:master Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomDietrich ThomDietrich ThomDietrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hnykda @ThomDietrich