Add metrics #607
Draft
Add metrics #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has a single trait and type to support metric collection and extraction for types in the crate. For now I've put it behind a metrics feature as it does require additional CPU cycles to collect, even if it's not used.
And use it everywhere.
It collects only one metric: number of accepted connections.
When a USR2 signal is received, same signal the runtime uses, it will log the metrics that a TcpListener collects, namely the number of accepted connections.
Need to actually start collecting them.
Thomasdezeeuw
force-pushed
the
rt-metrics
branch
from
2c00d5b
to
6e93e0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.