Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up Integration Modules #140

Merged
merged 5 commits into from
Sep 17, 2023
Merged

Clean Up Integration Modules #140

merged 5 commits into from
Sep 17, 2023

Conversation

DrParadox7
Copy link
Collaborator

Merged and refactored OreDictOsmium and OreDictPlatinum under PlatReplacement.
Cleaned up BoP and Silicon module.

@maggi373
Copy link
Member

can you make it so it supports pack that uses both oredicts?

@DrParadox7
Copy link
Collaborator Author

DrParadox7 commented Sep 14, 2023

Having both Osmium and Platinum as output messes up the ore processing.
What kind of compat do you have in mind?

@maggi373
Copy link
Member

maggi373 commented Sep 15, 2023

currently the silicon module is missing one of its oredicts. thats an issue need fixing

@maggi373
Copy link
Member

maggi373 commented Sep 15, 2023

for the platinum thingy, i just want to be able to use osmium in platinum recipes and platinum in osmium recipes. as minetweaker cant do the job, we have to bake it in. but its a time ago i added this and cant remember all the details, all i know its crucial to have for some of the factories on my server.

@maggi373
Copy link
Member

good catch with the bop integration tho

@DrParadox7
Copy link
Collaborator Author

for the platinum thingy, i just want to be able to use osmium in platinum recipes and platinum in osmium recipes. as minetweaker cant do the job, we have to bake it in. but its a time ago i added this and cant remember all the details, all i know its crucial to have for some of the factories on my server.

Minetweaker can do that very easily. Here:

<ore:ingotOsmium>.addAll(<ore:ingotPlatinum>); 
<ore:ingotPlatinum>.mirror(<ore:ingotOsmium>);

What it can't do is change the recipes

Merged and refactored `OreDictOsmium` and `OreDictPlatinum` under `PlatReplacement`.
Cleaned up BoP and Silicon module
@DrParadox7
Copy link
Collaborator Author

Minetweaker Script of the 2 compat as discussed:
https://pastebin.com/D6n65XJv

@maggi373 maggi373 merged commit e900821 into 1.7.10 Sep 17, 2023
1 check passed
@maggi373 maggi373 deleted the Cleaner-Plat-Compat branch September 17, 2023 11:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants