Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A cleaner merge of my changes #36

Merged
merged 10 commits into from
Sep 13, 2022

Conversation

DrParadox7
Copy link
Collaborator

Use this instead of #35

DrParadox7 and others added 8 commits September 11, 2022 18:41
From 200k+ RF/t to around 1.5k RF/t on lower injection rates.
Metallurgic Infuser now accepts any diamond oredictionary.
Fix Sawmill outputting ready-made rubber from logs instead of resin.
Users can now reduce particle effects emitted from completed multiblocks.
May enhance performance.
Regulate Heat Generator efficiency
Enable/Disable Heat Generator ability to output heat
@maggi373
Copy link
Member

it fails dude

@maggi373
Copy link
Member

a shit maven is down

@maggi373
Copy link
Member

you need to fix the error when compiling

@DrParadox7
Copy link
Collaborator Author

Alright. Fixed the sneaking lack of ";" and now it builds.

@DrParadox7
Copy link
Collaborator Author

These commits do not include anything that can now be done with Minetweaker (such as the steel manufacturing from Metallurgic Infuser) since you fixed that.

Copy link
Member

@maggi373 maggi373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gemdiamond compat needs to be removed as its already implemented from terralizationcompat

@@ -345,6 +344,12 @@ public static void init() {
InfuseRegistry.registerInfuseObject(ore, new InfuseObject(InfuseRegistry.get("DIAMOND"), 10));
RecipeHandler.addEnrichmentChamberRecipe(StackUtils.size(ore, 1), new ItemStack(Items.diamond));
}

for(ItemStack ore : OreDictionary.getOres("gemDiamond"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gemDiamond compat for enrichment chamber needs to be removed as its already implemented from terralizationcompat further down.

@maggi373 maggi373 merged commit 6160b5b into Thorfusion:1.7.10 Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants