Update versions #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few libraries were well behind in terms of versions. Here's an update to keep them up to date. Also, an addition the readme for ease of contribution
roblaszczak
reviewed
Jun 29, 2020
go.mod
Outdated
| github.com/ThreeDotsLabs/watermill v1.0.2 | ||
| github.com/golang/protobuf v1.3.2 // indirect | ||
| github.com/google/go-cmp v0.3.1 // indirect | ||
| cloud.google.com/go/pubsub v1.2.0 |
There was a problem hiding this comment.
as I see the newest version is v1.4.0, did you tried with that one? 😉
|
Thanks @mneumiller for the contribution 🎉 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping the versions up to date - had gotten behind. The go.mod versions also work with the
228gcloud sdk according to my local testing.Update the readme to help contributors jumping into the repo.