#2168 WatchKube discovery provider

[kick2nick]

Closes #2168

• Kubernetes service discovery provider based on watch requests #2168

Proposed Changes

• WatchKube service discovery provider that utilizes k8s watch api requests for efficient detection of changes.

It's proof of concept that needs improvements (see comments) and tests.
Tested locally, it works as expected, but with older versions of KubeClient which can be used with newer one after fix tintoy/dotnet-kube-client#163.

p.s. sorry for mess with #2173
Had no intention to force downgrade of KubeClient, will resume after fix)

[raman-m]

I've rebased the branch. Don't push please❗
But if you want to commit more, then you have to delete branch, fetch all, checkout the branch locally 👉

• git switch develop
• git branch -D 2168-watchkube
• git fetch --all
• git pull
• git checkout 2168-watchkube

And you will be able to contribute more 😉

[kick2nick]

Hi @raman-m , from my point of view all required stuff is done for moving to code review. Or am I missing something?

[raman-m]

The issue found at tintoy/dotnet-kube-client#163 was resolved by tintoy/dotnet-kube-client#164 and included in the release v2.5.12. However, this release has not been marked as the latest on the repository's releases page, where v2.5.10 is still listed as the most recent version. Could you please explain why v2.5.10 is considered the latest release?

[raman-m]

from my point of view all required stuff is done for moving to code review. Or am I missing something?

If you're confident and have completed the main development phase, can't you press the "Ready for Review" button?

[kick2nick]

Could you please explain why v2.5.10 is considered the latest release?

Have no idea, let's wait for the author's answer to your question.

[raman-m]

Hello, Nikolay!

While it's true that the PR seems partially ready for review following the closure of tintoy/dotnet-kube-client#163 and its subsequent release of v2.5.12, I am concerned that reviewing this PR may be premature due to the following dependencies:

1. This PR relies on #977 Enable validation of DI scopes in Kube and PollKube discovery providers #2180, which needs to be released beforehand as a part of the next 23.3.6 patch.
2. My plan is to include it in the November'24 milestone, which will prioritize the .NET 9 upgrade and migration to the net9.0 framework, with a lower priority assigned to introducing new features.

[raman-m]

Testing the new WatchKube type in ShouldReturnServicesFromK8s is necessary, but it is not sufficient for completing acceptance testing.

While it is well-tested by unit tests, there are no new acceptance tests for the proposed feature. Please review the scenarios of the current Kube and PollKube providers for inspiration. If Not, I will share my ideas later, in 1-2 weeks, after the release of the v23.3.6 patch.

[kick2nick]

This PR relies on #2180, which needs to be released beforehand as a part of the next 23.3.6 patch.

Not quite "relies", but conflicts on rebase will apear, I'll resolve them after #2180 merging.

My plan is to include it in the November'24 milestone, which will prioritize the .NET 9 upgrade and migration to the net9.0 framework, with a lower priority assigned to introducing new features.

No problem, I'll be in touch when you get back to this