Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct broken references in servicediscovery.rst #2187

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

emmanuel-ferdman
Copy link
Contributor

@emmanuel-ferdman emmanuel-ferdman commented Oct 29, 2024

Actual Behavior

Commit 59b63ea renamed OcelotServiceDiscovery to be ServiceDiscovery.

Expected Behavior

Links are workable.

Proposed Changes

  • Fixed references in the doc

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@raman-m raman-m added documentation Needs a documentation update Service Discovery Ocelot feature: Service Discovery labels Oct 29, 2024
@raman-m raman-m added this to the October'24 milestone Oct 29, 2024
@raman-m raman-m added the Oct'24 October 2024 release label Oct 29, 2024
Copy link
Member

@raman-m raman-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emmanuel, your attention to detail is impressive! Thank you!

@raman-m raman-m changed the title Correct broken service discovery references Correct broken references in servicediscovery.rst Oct 29, 2024
@raman-m raman-m merged commit 2796d59 into ThreeMammals:develop Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Needs a documentation update Oct'24 October 2024 release Service Discovery Ocelot feature: Service Discovery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants