Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from PyGithub:master #308

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

pull[bot]
Copy link

@pull pull bot commented May 9, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Co-authored-by: Juan Manuel "Kang" Perez <devel@kangmak.es>
@pull pull bot added the ⤵️ pull label May 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.10 ⚠️

Comparison is base (bab4180) 98.77% compared to head (e296dbd) 98.68%.

❗ Current head e296dbd differs from pull request most recent head 297317b. Consider uploading reports for the commit 297317b to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   98.77%   98.68%   -0.10%     
==========================================
  Files         117      117              
  Lines       11702    11745      +43     
==========================================
+ Hits        11559    11590      +31     
- Misses        143      155      +12     
Impacted Files Coverage Δ
github/Branch.py 88.17% <66.66%> (-4.33%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

amnuts and others added 26 commits May 12, 2023 09:47
Co-authored-by: Glenn McDonald <testworksau@users.noreply.github.com>
Co-authored-by: Nevins Bartolomeo <nevins@sev.co>
Adds support for new `create_fork` arguments:
 - `name` - To set the name of the fork on creation
 - `default_branch_only` - To only include the default branch

Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Co-authored-by: Steve Kowalik <steven@wedontsleep.org>
Note: This is a breaking change. The order of parameters of `PullRequest.get_review_comments` has changed to match other `get_comments` methods and Github API parameter order. Users should change `PullRequest.get_review_comments(since)` to `PullRequest.get_review_comments(since=since)`.

Calling without parameter is not breaking: `PullRequest.get_review_comments()`
This adds argument `auth` and deprecates `login_or_token`, `password`, `jwt`, and `app_auth` arguments of `github.Github`.

This adds argument `auth` and deprecates `integration_id`, `private_key` of `github.GithubIntegration`.

This deprecates the `create_jwt` method of `github.GithubIntegration`, replaced by `github.Auth.AppAuth.create_jwt`.
…ven (#2543)

Fixes slug attribute to fetch app when not set. Loads app with slug lazily, fetch complete app without slug.
Allows to refresh Github App user token. Integrates `ApplicationOAuth` into `github.Auth`.
- change deprecated parameter position to line
- add a parameter to allow multiline comment: start_line
- add a parameter to allow comment as suggestion: as_suggestion
- add more missing parameters: side, start_side, in_reply_to, subject_type
Moves `Github.get_app()` called without `slug` parameter into `GithubIntegration`, because it needs an `AppAuth`,
and we collect all such endpoints there. Calling `Github.get_app()` without `slug` parameter is now deprecated.

Replaces `datetime.utcnow()` with `datetime.now(timezone.utc)`, as it is deprecated in Python 3.12.
trim21 and others added 6 commits June 16, 2023 11:57
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Co-authored-by: Jonathan Leitschuh <jonathan.leitschuh@gmail.com>
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
@sfdye sfdye deleted the branch TiagoDanin-Forks:master June 20, 2023 23:26
@sfdye sfdye deleted the master branch June 20, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.