Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shop menu and Money System #156

Merged
merged 9 commits into from
Apr 21, 2024
Merged

Shop menu and Money System #156

merged 9 commits into from
Apr 21, 2024

Conversation

iquelli
Copy link
Collaborator

@iquelli iquelli commented Apr 17, 2024

Closes #43, #108

@iquelli iquelli changed the title Add base for shop menu Shop menu and Money System Apr 17, 2024
Copy link
Owner

@TiagoFar78 TiagoFar78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked that you created menus package, but I think Chest and Vault classes should stay on prisonbuilding package. They are more of a block than a menu. They just happen to have a menu to represent them.

@iquelli
Copy link
Collaborator Author

iquelli commented Apr 18, 2024

I liked that you created menus package, but I think Chest and Vault classes should stay on prisonbuilding package. They are more of a block than a menu. They just happen to have a menu to represent them.

But the part that's implemented in the class is the menu, not exactly anything related to where they are in the prison.

@iquelli
Copy link
Collaborator Author

iquelli commented Apr 18, 2024

Think we could name the classes VaultMenu instead for example? Not sure. But what about clickable and ClickReturnAction, can I leave them in menu package?

@TiagoFar78
Copy link
Owner

But what about clickable and ClickReturnAction, can I leave them in menu package?

Yes, and let Shop too.

Think we could name the classes VaultMenu instead for example? Not sure.

I don't think it is a good idea to change Vault and Chests name. Maybe the best ideia is to create a new class named VaultMenu and doing menu related things there. And in this case Vault would have a VaultMenu.

However, this is not that relevant and we don't have to worry that much about it since it is just a question of where to place classes. You can leave the code as it is right now.

Copy link
Owner

@TiagoFar78 TiagoFar78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@iquelli iquelli added the help wanted Extra attention is needed label Apr 20, 2024
@iquelli iquelli removed the help wanted Extra attention is needed label Apr 20, 2024
@iquelli iquelli marked this pull request as ready for review April 20, 2024 23:55
@iquelli iquelli requested a review from TiagoFar78 April 20, 2024 23:59
@iquelli iquelli self-assigned this Apr 21, 2024
@iquelli iquelli added the enhancement New feature or request label Apr 21, 2024
@iquelli iquelli requested a review from TiagoFar78 April 21, 2024 12:52
@TiagoFar78 TiagoFar78 merged commit 2aae824 into TiagoFar78:master Apr 21, 2024
2 checks passed
@iquelli iquelli linked an issue Apr 21, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Money system ENH: Implement shop menu
2 participants