-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shop menu and Money System #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked that you created menus package, but I think Chest and Vault classes should stay on prisonbuilding package. They are more of a block than a menu. They just happen to have a menu to represent them.
src/main/java/net/tiagofar78/prisonescape/items/SensorItem.java
Outdated
Show resolved
Hide resolved
src/main/java/net/tiagofar78/prisonescape/game/PrisonEscapePlayer.java
Outdated
Show resolved
Hide resolved
src/main/java/net/tiagofar78/prisonescape/items/CameraItem.java
Outdated
Show resolved
Hide resolved
But the part that's implemented in the class is the menu, not exactly anything related to where they are in the prison. |
Think we could name the classes VaultMenu instead for example? Not sure. But what about clickable and ClickReturnAction, can I leave them in menu package? |
Yes, and let Shop too.
I don't think it is a good idea to change Vault and Chests name. Maybe the best ideia is to create a new class named VaultMenu and doing menu related things there. And in this case Vault would have a VaultMenu. However, this is not that relevant and we don't have to worry that much about it since it is just a question of where to place classes. You can leave the code as it is right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job!
Closes #43, #108