Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World to Test Server #243

Merged
merged 2 commits into from
Jun 11, 2024
Merged

World to Test Server #243

merged 2 commits into from
Jun 11, 2024

Conversation

TiagoFar78
Copy link
Owner

Closes #242

@TiagoFar78 TiagoFar78 added documentation Improvements or additions to documentation test server Minecraft test server focus labels Jun 11, 2024
@TiagoFar78 TiagoFar78 requested a review from iquelli June 11, 2024 00:45
@TiagoFar78 TiagoFar78 self-assigned this Jun 11, 2024
@iquelli
Copy link
Collaborator

iquelli commented Jun 11, 2024

I think it would be better to leave the folder.

Or alternatively, add on the read-me an instruction to unzip the folder in the directory.

@TiagoFar78
Copy link
Owner Author

I have tested it using the folder and it changes files even when a player moves. So whenever you test something in the plugin it also change a lot of files in the world folder even if you didn't place any block. I think it is better to use the .zip file.

Copy link
Collaborator

@iquelli iquelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iquelli iquelli merged commit 1b6106d into master Jun 11, 2024
2 checks passed
@TiagoFar78 TiagoFar78 deleted the addWorldToServer branch June 11, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation test server Minecraft test server focus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: add Prison Escape World to TestServer Folder
2 participants