Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plugin.yml file and fixed small warnings. #64

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Conversation

TiagoFar78
Copy link
Owner

Created a plugin.yml that is needed to run a plugin in a minecraft server and fixed some warnings to have a clean plugin compilation.

@TiagoFar78 TiagoFar78 added enhancement New feature or request bug fix A fix for an existing bug labels Mar 23, 2024
@TiagoFar78 TiagoFar78 requested a review from iquelli March 23, 2024 23:10
@TiagoFar78 TiagoFar78 self-assigned this Mar 23, 2024
@TiagoFar78 TiagoFar78 marked this pull request as draft March 23, 2024 23:15
Copy link
Collaborator

@iquelli iquelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me so far

@TiagoFar78 TiagoFar78 marked this pull request as ready for review March 24, 2024 02:21
@TiagoFar78 TiagoFar78 requested a review from iquelli March 24, 2024 02:21
@TiagoFar78
Copy link
Owner Author

At this point, the commands '/pe start' and '/pe forcestop' are working

Copy link
Collaborator

@iquelli iquelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iquelli iquelli merged commit 24c0e41 into master Mar 24, 2024
@TiagoFar78 TiagoFar78 deleted the resources branch March 24, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix A fix for an existing bug enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants