Add wanted mark when player's in restricted area #88
Conversation
| @@ -97,7 +99,7 @@ public boolean hasIllegalItems() { | |||
| // ######################################## | |||
|
|
|||
| public boolean isWanted() { | |||
| return _isWanted; | |||
| return _isWanted || _inRestrictedArea; | |||
There was a problem hiding this comment.
You can never do this. You have to call isInRestrictedArea() whenever isWanted() is called. The name of a method tells you what it is supposed to do. Don't change it's purpose.
There was a problem hiding this comment.
I feel like it would make sense to have a function in player that would say if he can be arrested or not rather than adding 2 conditions everytime
There was a problem hiding this comment.
so I thought that adding it in the isWanted made sense
There was a problem hiding this comment.
but maybe I can create another function in client that will do that @TiagoFar78 instead of adding it to that one
There was a problem hiding this comment.
Ok sure that's a nice solution.
| return _inRestrictedArea; | ||
| } | ||
|
|
||
| public void setInRestrictedArea() { |
There was a problem hiding this comment.
Change name to enteredRestrictedArea
| _inRestrictedArea = true; | ||
| } | ||
|
|
||
| public void removeInRestrictedArea() { |
There was a problem hiding this comment.
Change name to leftRestrictedArea
Closes #59