Chests #98
Merged
Chests #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not checking pull requests
|
You have some commits that are not part of this PR |
|
Isn't that supposed? I thought it was because of rebase. |
No, did u use git push -f ? |
|
I'm scared that like this the code will be duplicated |
|
I don't think that is a problem because this commit uses BukkitWorldEditorClass and in the changed files there is nothing like that. I don't think we need to worry. |
|
Besides that there are no merge conflicts so I think it's alright. Even if this generates duplicate code I will fix it right away, but I don't know how to fix it in this branch without losing everything I have already done. |
|
Okay, but next time do:
|
iquelli
approved these changes
Apr 1, 2024
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was made in order to implement everything related to chests and other kind of containers arround the map.