CConnection: Modify UserPasswdGetter and UserMsgBox interface to CConnection #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Multiple connections is not something vncviewer can do presently, so I'm unclear for the need to refactor this? |
|
But I need multiple connections. So refactored it. |
|
Ah, that's right. You were using TigerVNC as a library. I just want to reiterate that this is not something we support, so it's best if you can align your needs with those of the TigerVNC project. That said, I see no need for these callbacks to be global, so this clean-up should be acceptable. |
CendioOssman
requested changes
Aug 6, 2024
|
I'm glad you can accept tigervnc as a library that supports multiple operating systems. I will help you achieve it. |
KangLin
force-pushed
the
password
branch
3 times, most recently
from
b81551f
to
406dbb2
Compare
CendioOssman
requested changes
Aug 8, 2024
KangLin
force-pushed
the
password
branch
4 times, most recently
from
7607ce2
to
420a2b1
Compare
CendioOssman
requested changes
Aug 13, 2024
KangLin
force-pushed
the
password
branch
3 times, most recently
from
c1a5df5
to
28d9039
Compare
CendioOssman
requested changes
Aug 15, 2024
KangLin
force-pushed
the
password
branch
3 times, most recently
from
70316e6
to
4b8f263
Compare
CendioOssman
requested changes
Aug 19, 2024
KangLin
force-pushed
the
password
branch
3 times, most recently
from
b43da5b
to
89c05d8
Compare
…nection Problems with the original code: A process can only establish one connection. After modification, multiple connections can be supported.
|
Committed as 1b0387a. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CConnection: Modify UserPasswdGetter and UserMsgBox interface to CConnection
Problems with the original code: A process can only establish one connection.
After modification, multiple connections can be supported.