-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pushing VFS down to converters #123
Pushing VFS down to converters #123
Conversation
e1d5862
to
b877256
Compare
763fbe3
to
e8385e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (left one optional comment, but feel free to implement or ignore).
tiledb/bioimg/converters/ome_tiff.py
Outdated
self, | ||
input_path: str, | ||
logger: Optional[logging.Logger] = None, | ||
config: Optional[Config] = None, | ||
ctx: Optional[Ctx] = None, | ||
extra_tags: Sequence[Union[str, int]] = (), | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self, | |
input_path: str, | |
logger: Optional[logging.Logger] = None, | |
config: Optional[Config] = None, | |
ctx: Optional[Ctx] = None, | |
extra_tags: Sequence[Union[str, int]] = (), | |
): | |
self, | |
input_path: str, | |
*, | |
logger: Optional[logging.Logger] = None, | |
config: Optional[Config] = None, | |
ctx: Optional[Ctx] = None, | |
extra_tags: Sequence[Union[str, int]] = (), | |
): |
It might be worth making optional arguments keyword only so that you don't need to worry about breaking the API when adding in new optional arguments. As implemented, if someone naively tried used the old API with only positional arguments, it would just pass extra_tags
to config
without a clear error message.
20479a5
to
6f38b8b
Compare
This PR:
Usage:
It will resolve related story [sc-25684] [sc-43577]