Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable package validation. #270

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

teo-tsirpanis
Copy link
Member

This PR uses the .NET SDK's package validation feature to validate that TileDB.CSharp does not have any backwards-incompatible changes, compared to a published version of the package (currently 5.5.0). If we need to introduce a breaking change, we will have to explicitly suppress the error.

I created an additional CI job that runs dotnet pack which will trigger the analysis, and will test it by trying to introduce a breaking change in the PR.

@teo-tsirpanis teo-tsirpanis marked this pull request as ready for review September 6, 2023 19:47
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks

@teo-tsirpanis teo-tsirpanis merged commit f4b7f6e into TileDB-Inc:main Sep 6, 2023
4 checks passed
@teo-tsirpanis teo-tsirpanis deleted the package-validation branch September 6, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants