Update Core to 2.18 #325
Merged
Update Core to 2.18 #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #29964: [CSharp] Support aggregate pushdown. |
`tiledb_channel_operator` does not have a free function so it does not need a safe handle.
teo-tsirpanis
force-pushed
the
update-2.18
branch
from
39437b4
to
4822e62
Compare
teo-tsirpanis
commented
Dec 14, 2023
| /// <remarks> | ||
| /// This class abstracts the <c>tiledb_channel_operation_t</c> type of the TileDB C API. | ||
| /// </remarks> | ||
| public abstract class AggregateOperation |
There was a problem hiding this comment.
I named this AggregateOperation instead of ChannelOperation or QueryChannelOperation. I believe it conveys its meaning better, and the first alternative is confusing (what is a channel?), and the second alternative is long.
This is a managed class that does not directly contain a tiledb_channel_operation_t*. Instead it encapsulates the logic to create it, which gets done when actually passed to the C API.
| /// <remarks> | ||
| /// This class abstracts the <c>tiledb_channel_operator_t</c> type of the TileDB C API. | ||
| /// </remarks> | ||
| public abstract class AggregateOperator |
There was a problem hiding this comment.
Same as AggregateOperation.
shaunrd0
approved these changes
Dec 15, 2023
|
Feedback addressed, CI is green, I'm going to merge it… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-29964