Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema evolution delete test. #338

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

teo-tsirpanis
Copy link
Member

@teo-tsirpanis teo-tsirpanis commented Dec 9, 2023

SC-38119

TileDB-Inc/TileDB#4549 fixed array time travelling to honor the starting and ending timestamps when opening the schema.
In the test the array's timestamp had been set by a previous call to TestUtil.ReadArray in a range that excluded the remaining attribute.

This PR resets the timestamp range before writing the array schema. The test has been verified to be fixed on my machine.

Fixes #334
Fixes #335
Fixes #337

Copy link

This pull request has been linked to Shortcut Story #38119: Dropping an attribute seemingly has no effect..

Copy link
Contributor

@shaunrd0 shaunrd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 👍

@teo-tsirpanis teo-tsirpanis merged commit 716797d into TileDB-Inc:main Dec 11, 2023
4 checks passed
@teo-tsirpanis teo-tsirpanis deleted the fix-deletes-schemaevo branch December 11, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants