Reapply simplification of memory handling with generics. #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetorpedodog
requested review from
NullHypothesis,
ypatia,
shaunrd0 and
snagles
as code owners
|
The test I just added fails without the fix (i.e., commit 2a546a8) and passes with it. |
snagles
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #331 and #330, thus reintroducing #248 and #321.
The issue in those changes was that when attempting to copy a null/zero-length string, we would do something like
C.GoStringN(nil, 0)or maybeC.GoStringN(someInvalidAddress, 0). Either of those should (in theory) give you a zero-length string, but in practice we want to manually check (as the code did before I removed that check). The check remained present in the other uses, since they all had an equivalent check before their copying operation ingetValueInternal.This change is also currently running through a server-side test suite.