Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.22. #361

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Update to Go 1.22. #361

merged 2 commits into from
Dec 18, 2024

Conversation

shaunrd0
Copy link
Collaborator

This updates to use Go 1.22, since Go 1.21 reached EOL 4 months ago.

@shaunrd0 shaunrd0 requested a review from a team as a code owner December 18, 2024 16:34
@teo-tsirpanis
Copy link
Member

Now that min is available, can you use it in these cases?

TileDB-Go/buffer.go

Lines 138 to 143 in f20011a

var sizeToRead int
if availableBytes > math.MaxInt {
sizeToRead = math.MaxInt
} else {
sizeToRead = int(availableBytes)
}

TileDB-Go/buffer.go

Lines 174 to 180 in f20011a

// TODO: Use min on Go 1.21+
var writeSize int
if remaining > math.MaxInt {
writeSize = math.MaxInt
} else {
writeSize = int(remaining)
}

Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shaunrd0 shaunrd0 closed this Dec 18, 2024
@shaunrd0 shaunrd0 reopened this Dec 18, 2024
@shaunrd0
Copy link
Collaborator Author

@TileDB-Inc/tiledb-cloud-core Blocked on merging this because of required CI checks for Go 1.20. Can someone with access check on the required workflows for TileDB-Go to replace 1.20 with 1.22? I think there is likely a branch protection rule or something in repository settings that I don't have access to

@NullHypothesis
Copy link
Collaborator

@TileDB-Inc/tiledb-cloud-core Blocked on merging this because of required CI checks for Go 1.20. Can someone with access check on the required workflows for TileDB-Go to replace 1.20 with 1.22? I think there is likely a branch protection rule or something in repository settings that I don't have access to

I remember running into this problem in the past. Can you try opening a new PR?

@teo-tsirpanis
Copy link
Member

I don't think it needs a new PR. Someone with permissions (@Shelnutt2?) needs to update the branch protection rules.

@shaunrd0 shaunrd0 closed this Dec 18, 2024
@shaunrd0
Copy link
Collaborator Author

I remember running into this problem in the past. Can you try opening a new PR?

Yep no luck.. worth a shot though! #362

I'll just reopen this and close the new PR. Sorry for all the noise 😅

@shaunrd0 shaunrd0 reopened this Dec 18, 2024
@NullHypothesis
Copy link
Collaborator

I don't think it needs a new PR. Someone with permissions (@Shelnutt2?) needs to update the branch protection rules.

@snagles is also known to have superpowers.

@Shelnutt2
Copy link
Member

@shaunrd0 and @NullHypothesis you have leveled up to "maintainer". New quests have been unlocked in the "settings arena". Go forth and tame the CI settings.

@teo-tsirpanis
Copy link
Member

It needs admin permissions.

@shaunrd0
Copy link
Collaborator Author

It needs admin permissions.

👍 Yep, now I can access the Settings panel but can't view or modify branch protection rules.

@shaunrd0 shaunrd0 merged commit 8004151 into master Dec 18, 2024
24 checks passed
@shaunrd0 shaunrd0 deleted the smr/update-go-1.22 branch December 18, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants